ome / bioformats

Bio-Formats is a Java library for reading and writing data in life sciences image file formats. It is developed by the Open Microscopy Environment. Bio-Formats is released under the GNU General Public License (GPL); commercial licenses are available from Glencoe Software.
https://www.openmicroscopy.org/bio-formats
GNU General Public License v2.0
370 stars 241 forks source link

Repeated conditional test II #4160

Closed scuniff closed 3 months ago

scuniff commented 3 months ago

Regarding:

https://github.com/scifio/bioformats/blob/6bcf6b9d284686416f3458c8893fbcf4ebcdecfd/components/forks/poi/src/loci/poi/hssf/record/SSTRecord.java#L455

Should it be:

if (bucketAbsoluteOffsets == null || bucketRelativeOffsets == null)

sbesson commented 3 months ago

This fork has been removed from the Bio-Formats code base on the development line. Additionally the commit points to a fork. Closing as invalid