Closed mtbc closed 8 years ago
Not having an alternative proposal, I would think we unify by adding the markers to OMERO.
Enumerations for MarkerStart and MarkerEnd are
Any idea's how a Circle and Square are displayed on the end of a line? E.g are they centred at the x,y coordinate, or fit inside it (like the Arrow does in OMERO.figure)?
Do they have a fixed size? In OMERO.figure, I try to make a suitable-sized Arrow based on the line width, so maybe the same approach would apply to Circle and Square? Do we even have any need for Circle and Square? Maybe we should only support Arrow?
The current list of Graffle supported arrow heads:
The current plan is to add markerStart
and markerEnd
to OMERO but to restrict OME-XML Marker
to simply Arrow
for the meantime.
Fixed by https://github.com/openmicroscopy/bioformats/issues/2286 in https://github.com/openmicroscopy/bioformats/pull/2286/commits/a84850bab3d731a555cbb6f4441cc616e9a62b50 and by https://github.com/openmicroscopy/openmicroscopy/issues/4533 in https://github.com/openmicroscopy/openmicroscopy/pull/4533/commits/f1073105de8eaf937a16ac2d93f8041562e8963f.
The OME-XML schema at http://www.openmicroscopy.org/Schemas/Documentation/Generated/OME-2015-01/ROI_xsd.html has
markerStart
andmarkerEnd
properties on lines. These are absent among OMERO's model objects but are clearly anticipated by https://github.com/openmicroscopy/openmicroscopy/blob/037f0caf/components/model/resources/mappings/roi.ome.xml#L70.Should String-based
markerStart
andmarkerEnd
properties be added to OMERO'sLine
andPolyline
? Perhaps some other change would be better to bring the two schemas into line?