ROI: Folders Measurement Tool - Alternative workflow

[will-moore]

This is an alternative workflow for adding Folders to the measurement tool, to fix a couple of issues with the current workflow.

• Display ROI Folders -> Select All. No way to undo this and get back to just showing Folders that contain ROIs. You have to close the image viewer and reopen it.
• When filtering Folders, can't add ROIs to them
• We currently have 'Display ROI Folders' -> 'Select All' AND a 'Show all ROI Folders' checkbox. This is really confusing since they have partially mutually-exclusive (but different) behaviours.

In this scenario, we add Folders to the ROI table with an "Add Folder" button in the toolbar...

...that opens a full dialog where we can filter ALL OMERO folders and create new ones:

Once we have the Folders we want, we can organise ROIs into them by drag-n-drop as in the current behaviour. The right-click menu can also be used to "Add to Folder" with a submenu of Folders that are currently in the measurement tool ROI table. We can still filter the Folders in the ROI table as with current behaviour.

The same right-click menu is available on Shapes themselves in the viewer. This allows quicker sorting of Shapes/ROIs into folders (without launching a dialog each time). Might even be able to add keyboard shortcuts so you can just click a Shape and use keyboard to add it to folder?

Other thoughts not in screenshots:

• Right-click "Add to Folder" submenu could include "Add Folder..." as a short-cut to open the Add Folder dialog above.
• Toggle a folder visibility actually clears all the visible/hidden flags on children (instead of hiding children while maintaining their visible checked status see https://github.com/openmicroscopy/design/issues/11#issuecomment-181842552) Current behaviour has some funny behaviour when ROIs in multiple folders.
• It would also be nice to cleanup the table by removing the 'Type' column, using the shape icon at the left of each row instead of the same ellipse icon for every shape. Also the Comment column could go, with the comment moved to the left (same as Folder name).
  • The Folder icon would be better not to include the ROI glyph. Just a plain Folder icon with a colour different from the ROI icon would make it more distinctive.

[pwalczysko]

Quite like everything here except for the Toggle a folder visibility .... suggestion - do not see anything wrong with the current behaviour.

The

When filtering Folders, can't add ROIs to them

is acutally a Bug for me, nobody intended such behaviour I think. Edit: this behaviour actually works as troubleshooted with @will-moore . What is problematic is the situation when a ROI is already in one folder, than I cannot easily add it to another folder, because the ROI is not listed anymore.

[will-moore]

Following discussion with @jburel @dominikl @gusferguson @pwalczysko @sbesson: Focus should be on a dialog to "Add Folders" to the table (screenshot 2 above) instead of needing to add all folders to the table. Other changes can be considered later. But the idea of the "Add to Folder" dialog (launched from an ROI/Shape) allowing user to choose between "Folders on the Image" (default) or "All Folders" was suggested as a next TODO, since then you could access all folders while working on the image viewer as well as the ROI table. Proposed changes to be detailed on https://trello.com/c/CONobAmi/57-roi-folders-insight-follow-up prior to starting work.

[will-moore]

@pwalczysko See this scenario in which TestEllipses folder contains ROIs that are also in the testArrows folder above. This is before clicking on Folder: TestEllipses

When I uncheck the visibility of TestEllipses, I'd expect the child ROIs to be hidden.... And this is after clicking on it: Some of the child ROIs that were previously hidden are now shown.

I have also lost the 'checked' status of all child ROIs. If I had a large number of these in various checked/uncheck states, and I just wanted to hide them all, then re-show the checked ones, I can't do that since the info is lost.

[pwalczysko]

When I uncheck the visibility of TestEllipses, I'd expect the child ROIs to be hidden.... And this is after clicking on it: Some of the child ROIs that were previously hidden are now shown.

Yes, this might be confusing but why would you disable the whole folder except you want to do a batch action ? I mean, the showing of those ROIs is informing you that these ROIs are also in some other folder as well. The loss of the granularity inside the folder is something to consider, maybe in some later time ?