Open will-moore opened 8 years ago
Similar to my comments under https://github.com/openmicroscopy/openmicroscopy/pull/4630#issuecomment-223915741 as well as the design issue 23, a longer-term goal here might be to have an extension be able to plug itself in so that, e.g., one could filter by "Gene" (which would tie together with the left- & right-hand panels)
cc: @aleksandra-tarkowska
This is nice feature, @will-moore and I discussed few issues:
Personally building filter query like shown above is nice feature but looks complected, maybe we could come up with the most popular one. Not sure.
Q: will that be supported by the top URL? like ?show=dataset-5&rate=3
As currently sketched out above, there are a number of issues, including some of the ones we ran into when we looked at improving centre pane filtering in Insight we ran into a number of problems - in short:
Note: We have been thinking of doing this addition of different filter terms before - and it proved a bit problematic.
One of the best places this is done is in Mac Mail - as shown in screenshots below.
If it is possible to do it as well as Mail does it, then it is probably worth doing.
Suggested approach - taking some cues from the Mail example.
Start with filter box.
Click in and get drop-down options to select field to filter on. This list can be built up incrementally as time allows.
Select level of rating to filter for (any technical issues glibly ignored).
Field/parameter box in Filter box can be individually removed with parameter box X or all removed with Filter box X.
Select addition field - such as name.
Get text box within filter box - enter text - drop-down gives dynamic results. Hit return to set text in box or select result and hit return.
Add further filter criteria as desired.
Looks good @gusferguson. Similar to what I proposed, with the addition of the X for each filter. I think, as @aleksandra-tarkowska suggested that ratings, comments, tags etc should default to "added by any user" and we could think about whether we'd need to provide the option of "mine only". NB: this is different behaviour from Insight where E.g. ratings only support "mine only".
Carrying on from the tagexport suggestions, @eleanorwilliams in discussion with Rafael suggests that each "virtual table" registered with the plugin (like "phenotype", "gene", etc) could/should also provide a filter similar to "Has ROI" or "No ROI", i.e. "Has Phenotype" or "No Phenotype".
From PR & discussion at https://github.com/openmicroscopy/openmicroscopy/pull/4694
Want to be able to add filtering options but not initially support everything that Insight does.
E.g. start with simple filter chooser...
Choose from Rating, Name (could later add Tag, Comment etc). E.g. choose rating...
Then you can add more filters...
E.g. filter by name...
Can keep adding more filters as needed.