ome / design

OME Design proposals
http://ome.github.io/design/
1 stars 15 forks source link

Filter images by rating, name etc #39

Open will-moore opened 8 years ago

will-moore commented 8 years ago

From PR & discussion at https://github.com/openmicroscopy/openmicroscopy/pull/4694

Want to be able to add filtering options but not initially support everything that Insight does.

E.g. start with simple filter chooser...

screen shot 2016-06-06 at 11 20 28

Choose from Rating, Name (could later add Tag, Comment etc). E.g. choose rating...

screen shot 2016-06-06 at 11 25 58

Then you can add more filters...

screen shot 2016-06-06 at 11 27 02

E.g. filter by name...

screen shot 2016-06-06 at 11 32 09

Can keep adding more filters as needed.

joshmoore commented 8 years ago

Similar to my comments under https://github.com/openmicroscopy/openmicroscopy/pull/4630#issuecomment-223915741 as well as the design issue 23, a longer-term goal here might be to have an extension be able to plug itself in so that, e.g., one could filter by "Gene" (which would tie together with the left- & right-hand panels)

cc: @aleksandra-tarkowska

atarkowska commented 8 years ago

This is nice feature, @will-moore and I discussed few issues:

Personally building filter query like shown above is nice feature but looks complected, maybe we could come up with the most popular one. Not sure.

Q: will that be supported by the top URL? like ?show=dataset-5&rate=3

gusferguson commented 8 years ago

As currently sketched out above, there are a number of issues, including some of the ones we ran into when we looked at improving centre pane filtering in Insight we ran into a number of problems - in short:

Note: We have been thinking of doing this addition of different filter terms before - and it proved a bit problematic.

One of the best places this is done is in Mac Mail - as shown in screenshots below.

mail1

mail2

mail3

If it is possible to do it as well as Mail does it, then it is probably worth doing.

Suggested approach - taking some cues from the Mail example.

Start with filter box.

1 centre pane filtering-start

Click in and get drop-down options to select field to filter on. This list can be built up incrementally as time allows.

2 centre pane filtering-click-in

Select level of rating to filter for (any technical issues glibly ignored).

3 centre pane filtering-select-rating

Field/parameter box in Filter box can be individually removed with parameter box X or all removed with Filter box X.

4 centre pane filtering-rating-box

Select addition field - such as name.

5 centre pane filteringselect-name

Get text box within filter box - enter text - drop-down gives dynamic results. Hit return to set text in box or select result and hit return.

6 centre pane filtering-start-typing

Add further filter criteria as desired.

7 centre pane filtering-select-commented

8 centre pane filtering-name-box-comment

will-moore commented 8 years ago

Looks good @gusferguson. Similar to what I proposed, with the addition of the X for each filter. I think, as @aleksandra-tarkowska suggested that ratings, comments, tags etc should default to "added by any user" and we could think about whether we'd need to provide the option of "mine only". NB: this is different behaviour from Insight where E.g. ratings only support "mine only".

joshmoore commented 8 years ago

Carrying on from the tagexport suggestions, @eleanorwilliams in discussion with Rafael suggests that each "virtual table" registered with the plugin (like "phenotype", "gene", etc) could/should also provide a filter similar to "Has ROI" or "No ROI", i.e. "Has Phenotype" or "No Phenotype".