ome / design

OME Design proposals
http://ome.github.io/design/
1 stars 15 forks source link

Scoping of Well-Field Grid View - Round 3 #52

Open gusferguson opened 8 years ago

gusferguson commented 8 years ago

Following feedback and discussion on the first round of mockups: Scoping of Well-Field Grid View - Round 2 - https://github.com/openmicroscopy/design/issues/51

Note: For convenience mockups show OMERO.insight only - exactly the same will be done in OMERO.web.

Comments addressed:

From @jburel

Grid in spatial view

wellgridview-spatial-view-bottom-grid-tooltip

From @bramalingam

Using abstracted well for position grid in LHP

46 Fields in Well

wellgridview-grid-spatialbe-tooltip-small

Larger squares in LHP position grid

wellgridview-grid-spatialbe-tooltip

13 Fields in Well

wellgridviewgrid-bottom-spatial-be

To follow:

From @will-moore - need to show whether focus on Well vs Field

bramalingam commented 8 years ago

The spatial view with the grid layout in the background in the LHP looks the best. Another small issue to think about, what happens to this view when multiple wells are selected.

There can be wells with different number of fields and the spatial view might break down in that case. (in a multi-select scenario) : May be show the combined set of fields for all selected wells in the spatial view (just to highlight the coverage within the well)?

And also are we synchronising the selections on spatial view (LHP) to the fields selected on the RHP?

will-moore commented 8 years ago

Looking good. Spatial view with little squares in LHP works well. @bramalingam Good point about multiple Well selection - I guess we just show the sum of all the fields in the spatial view. Do we always show the spatial view if we have spatial info? OR show it by default and allow it to be hidden? OR not show it by default and allow it to be shown? I guess the cost of loading the spatial data is pretty low, since we are already loading all the WellSamples for the selected Well(s), so maybe nice to show it by default. @bramalingam I'm assuming we're sync'ing the selections and you can use the spatial view squares OR the Image Thumbnails to change the selection.

bramalingam commented 8 years ago

Am very keen on viewing the spatial info. I've often been asked about the position of the Well/Field for QC purposes. Just thought I'd highlight the multi-selection point. Yes sum of all fields looks like the most straight-forward approach.

And I like the smaller squares (in the spatial view with the grid), larger and overlapping squares gives one the feeling, that the fields are overlapping, which might not be the case in most situations.

Syncing the spatial view with the fields might be tricky in multi-select cases , do we show just the selected field alone in the column data for the fields? (sounds like the obvious thing to do) when F1 is selected in a the LHP:

Field view can look like :

        F1
W1
W2
W3

when the default view(without any selections on the spatial view) looks like :

      F1   F2   F3
W1
W2
W3
gusferguson commented 8 years ago

Additional mockups:

wellgridview-multi-well-select-no-field-spatial-be

wellgridview-multi-well-field-select-spatial-be

@bramalingam

show just the selected field alone in the column data for the fields?

Not sure this is viable as it adds yet another permutation to the displays - risk of user confusion is increased.

Note:

I think that in the spatial view in centre pane - zoom should zoom whole pane - grid and all, not just fields as currently done.

dsudar commented 8 years ago

Sorry for coming late into this discussion. Probably means I'm missing lots of earlier considerations.

jburel commented 8 years ago

@dsudar: Thanks for the feedback, very useful. "grid view" is the non-spatial view (display as row/column) The mockups are done using insight solely for convenience. The change will be applied to Web too

gusferguson commented 8 years ago

@dsudar - thanks very much for the feedback and comments

assumes that the fields have usable coordinates. What would the default behaviour be if coordinates are missing

Perhaps the best thing to do would be to only activate the spatial view option if the coordinate data were there. ? if this is possible/too much overhead?

One thought: can a reasonable guess be deduced from the spatial information (even when not displaying in spatial view)?

Would the guess not be better based on the width of the centre pane? i.e just wrap them

And when a user selects a preferred "No. in Row", any thought how to make that "sticky" so the user doesn't have to keep setting it back to the preferred amount?

I should think this could be done.

Removing circle in LHP birds-eye spatial view.

wellgridview-multi-well-field-select-spatial-be-rect-grid

will-moore commented 7 years ago

@chris-allan As I'm starting to implement this in web, it would be good to know what implications these changes would have on Glencoe. E.g. having plate Wells be square & zoomable instead of using the config opt.width & opt.height with default of 64x48. (I'm still using size 96 for the actual thumbnails, so no change there).

gusferguson commented 7 years ago

Suggestion moved to #58