ome / design

OME Design proposals
http://ome.github.io/design/
1 stars 15 forks source link

Web Viewer - Implementation - ROI Drawing - Step 3 #59

Open gusferguson opened 7 years ago

gusferguson commented 7 years ago

Follows on from: Web Viewer - Brainstorm - Concepts on New Interaction Approaches - 1 #32 Web Viewer - Brainstorm - Concepts on New Interaction Approaches - 2 #34 Web Viewer - Brainstorm - Concepts on New Interaction Approaches - 3 #36 Web Viewer - Implementation - Step 1 #45 Web Viewer - Implementation - Step 2 #46

Drawing together mockups and feedback for the third step in implementing the new Web Viewer.

Scope:

ROI Tab in Right-hand Pane

Drawing Mode accordion tab

Propagate tab open by default - deselected by default

webviewerstepsdrawingmode

If Propagate selected.

webviewerstepsdrawingmodepropagate

Options selectable in the Drawing Mode tab:

webviewerstepsdrawingmodeattachcurrent

Options:

Copy and paste functionality is in Edit button Drop-down.

Menu for Delete button Drop-down:

webviewerstepsroisdeletedd

Menu for Edit button Drop-down webviewerstepsroiseditdd

jburel commented 7 years ago

@gusferguson: looks good for the first step. This a lot. I am not sure that the propagate tool (dialog) is necessary. It might be good to discuss it with @mporter-gre since he has a good number of users using mtools for ROI. I will probably exclude the dialog for the first round

A copy/paste of ROI across images will more useful (required a different mock-up) We now need to create a doc similar to https://github.com/openmicroscopy/design/pull/56 indicating how rois are saved i.e. when the z/c/t are set.

gusferguson commented 7 years ago

@jburel I think we need to enable people to do things as they do at the moment, particularly if it is still done like that in Insight. If something has to go then I would advocate doing the dialog first, so at least current workflows are not disrupted, and then the new way second. I will speak to Michael and see what he thinks. I will start on the copy and paste and the saving doc.

jburel commented 7 years ago

I am not sure many people used the propagation tool, since it can be flaky and not really useful when there is a large number of z or t. But unfortunately we do not have metrics for that that's why mtools propagation feature has proved to be much more popular

gusferguson commented 7 years ago

@jburel Discussed with @mporter-gre Likes the new way of drawing ROIs as mocked up. Suggested clarifying wording for attaching to Z and T as viewing (Gus - will work on it) Although have to use graphical propagation tool in Insight agrees with J-M it will be fine to not have it in Web - at least at first step. Will revise the mockups in this light. Will look at copy-paste.

gusferguson commented 7 years ago

Mockups updated to remove Copy and Paste buttons from toolbar and show Drop-down menu options for Delete and Edit buttons (which includes copy paste).

waxenegger commented 7 years ago

thank you @gusferguson

the pictures definitely help me clear up some questions I had about what's behind some dropdowns/otions.

I think the mock-ups are great, in general, and at this point in time much nicer to work with than technical documentation. I suppose the detail of the latter is needed at some point but to get in basic/existing functionality the visuals illustrate really well what's supposed to happen.