search

ome / design

OME Design proposals
http://ome.github.io/design/
1 stars 15 forks source link

ROI: styling ROIs #6

Open atarkowska opened 8 years ago

atarkowska commented 8 years ago

Would be very conviction to have full flexibility on defining style on ROI and its label text. That contains: color, font, background, width, position, etc. Currently it required to create more then one ROI (for example: shape and text).

mtbc commented 8 years ago

Probably could use multiple shape instances (label, rectangle, etc.) in the same ROI? Does https://trello.com/c/q0FA2e4Q/32-label-position help at all: i.e. are there small changes we could usefully try to get into even the next model release?

ghost commented 8 years ago

The meaning of a ROI "label" is unclear. I assume you're referring to the Shape Text attribute rather than the separate Label ROI type? That is, it's currently just a text string, with no implied rendering intentions. OMERO chooses to render it in the centre of the ROI, but there are no rendering settings to control this specifically.

I think before deciding to do this or not, we really need to be clear on what the intended purpose of this property is. It might be descriptive, and not intended for rendering at all. And we need to be clear on the uses for label text over adding a separate Text region.

Other ROI models allow positioning of a label relative to the bounding box of the region, as well as having font and colour properties. We would need to add such properties to all region types to do this. And for things like background, that gets complicated since you then have a box which isn't related to the ROI or the size of the text--it might need to be bigger than the text bounds which would require yet another property or hardcoded renderer behaviour.