ome / design

OME Design proposals
http://ome.github.io/design/
1 stars 15 forks source link

chown in clients #77

Open pwalczysko opened 7 years ago

pwalczysko commented 7 years ago

Scoping of Change Owner

Group Owners and Admin to be given ability to change owner of data in their groups.

Use Cases:

• user leaves lab/institute and ownership of data needs to be transferred to another researcher. • one user imports data for another user.

Options:

Perform on selection of:

Presume:

Will allow selection of data belonging to more than one owner. Will allow owner to be “changed” to same owner, so if there is data in dataset owned by several users, including the “new owner” - so the group owner does not have to worry to separate those out. The ownership of any annotations attached to images will be unaffected.

Using right-click menu

New owner selection and confirmation dialog.

Images only selected: picture1

Dropdown menu allows selection of new owner: picture2

Dataset selected: picture3

Project selected: picture4

To deal with the requirement to change all data in all groups belonging to a user in one go:

pwalczysko commented 7 years ago

@will-moore @jburel @mtbc @joshmoore : See above what I found as Word doc done by Gus and re-formatted it here to github issue format.

I think this is a workable prototype, questions:

pwalczysko commented 7 years ago

also see https://trello.com/c/0icOEIqM/12-rfe-enable-creation-of-p-d-s-on-behalf-of-others-in-web#comment-58fa0bdf0e975a5deee1b5f3 - these two workflows (create container for others and chown) have to be thought through

mtbc commented 7 years ago

In RW groups chown still won't want to descend into mixed-owner container hierarchies, one'd have to specify all the target objects explicitly; probably the same for annotations.

mtbc commented 7 years ago

(Below RW chown will sometimes do some unlinking or deletion: e.g., chowning an image in a RA group probably unlinks it from datasets.)

pwalczysko commented 7 years ago

chowning an image in a RA group probably unlinks it from datasets.)

Yes, it does, tested on eel merge.

pwalczysko commented 7 years ago

Situation: user-in-RA's-Project-admin's-link-admin's-dataset-user-in-RA's-Image hierarchy

Chown on the Project (to another user in RA) will unlink the Project to the Dataset. I do not see a justification for this, to be honest. This does not follow the logic because it could not have been created in that group in the first place, it must be severed. No, this could (and was) created by the admin in that group.

Edit: And adding --include Image does not help, the hierarchy gets broken anyway, the image will not be chowned. Edit: And specifying "all images under that project" using Project/Dataset/Image:ProjectID does not help either when the hierarchy is mixed, no images will get chowned.