ome / design

OME Design proposals
http://ome.github.io/design/
1 stars 15 forks source link

Project Dataset Image Folders #87

Open will-moore opened 6 years ago

will-moore commented 6 years ago

"More levels" has been a feature request for a long time. More recent examples: https://www.openmicroscopy.org/community/viewtopic.php?f=4&t=8419 Also feedback from TIM 2018 meeting and IDR mailing lists.

Several design decisions needed to consider:

Folder structure

To start assessing some options, I began a prototype in the webclient, https://github.com/will-moore/openmicroscopy/tree/project_folders simply using Tags with a 'project.folder' namespace as a backend for representing folders. These contain Projects only in the current implementation.

screen shot 2018-03-20 at 15 08 42

Already we can see this is probably a bit confusing with all the various containers in the tree (this is with omero.client.ui.tree.type_order=False so all containers are mixed together). So probably a good time to consider some of the options above.

cc @pwalczysko @jburel @chris-allan @joshmoore @sbesson

joshmoore commented 6 years ago

Some initial thoughts:

Do we need/want many-to-many relationships, or should each Folder have just a single parent?

Folders as they currently stand are one-to-many, but the contents can be in multiple folders.

Do we simply add more levels on top of Screens/Projects,...just put Images into Folders

If it's "just put the import item" (i.e. images or plates) in folders, then I could see that.

How do we distinguish between Folders that are Image/Plate containers and others (e.g. ROI Folders)?

Annotation folders come quickly to mind. At the moment, they are strongly typed so it shouldn't be difficult to differentiate if we don't change the strategy:

will-moore commented 6 years ago

OK, so if we get rid of Projects and Datasets then that'll happen at upgrade time, with a script that converts Projects and Datasets and Screens to AnnotationFolders. If AnnotationFolders only have a single parent, we'd have to handle Datasets in multiple Projects somehow? Also, getting rid of Datasets mean things like OMERO.scripts, iviewer etc have to handle Folders instead of Datasets.

joshmoore commented 6 years ago

with a script that converts Projects and Datasets and Screens to AnnotationFolders.

To ImportFolders? (or whatever they're called)

Also, getting rid of Datasets mean things like OMERO.scripts, iviewer etc have to handle Folders instead of Datasets.

Yeah, there's going to be a long list of things like this. If keeping Datasets keeps most things simple, then I could imagine keeping them, but that will increase the long-term complexity.

mtbc commented 5 years ago

Folders at present can contain a mix of ROIs and images. I think this heterogeneity may be a feature allowing users to organize objects by what they relate to rather than what they are. It may depend in part on how we someday represent correlative imaging, etc. Tightly typed folders are certainly an option though.

jburel commented 5 years ago

Such feature was again mention during the latest training session in Singapore