ome / design

OME Design proposals
http://ome.github.io/design/
1 stars 15 forks source link

OMERO.figures linked to Image-of-a-Figure #96

Open will-moore opened 6 years ago

will-moore commented 6 years ago

We want to be able organise figures in much the same way we can organise Images https://trello.com/c/LwAVYUjm/165-save-figures-in-folders

Adding File-Annotation support to Tagging, Project/Dataset (folders), and even OMERO.parade would be a lot of work and would also not provide a thumbnail / preview of the figures you are working with.

However, if we were to save the Figure as an OMERO Image and keep the Image-of-a-Figure linked to the figure FileAnnotation, then we can use all the existing functionality for organising Images.

We can already 'export' a Figure as a new Image in OMERO (currently this has no link back to the original figure file), but several changes are needed to make this workflow visible and easy to use. In particular, we need to keep the Figure and Image-of-a-Figure in sync as one entity.

Potential issues:

jstitlow commented 6 years ago

Re: the first Potential issue: Tagging, Dataset specification, KV, etc. could be added in either the File dropdown menu (Add Figure Annotation...) or/and in the Info panel when no images are selected.

image

jstitlow commented 6 years ago

Is it possible to increase resolution of thumbnails in the OMERO web client center panel? Thumbnails at the current res are not interpretable, e.g., compare thumbnail to preview:

image

mtbc commented 6 years ago

There is a omero.client.browser.thumb_default_size configuration property which may help?

will-moore commented 6 years ago

So https://github.com/openmicroscopy/design/issues/96#issuecomment-394691601 gets to the crux of this solution: The idea is that we can avoid re-building a Project/Dataset & Tagging workflow in figure itself (and the browse by Project/Dataset/Tag too). I guess the way this would work is File > Tag this figure in OMERO which would open the corresponding Image-of-a-Figure in webclient. However, this wouldn't be enabled until you had saved the Figure (including creation of the Image). So you'd have to disable the "Tag this figure in OMERO" option, with a tooltip "Save the figure to enable Tagging". I know this is a little clunky, but if we are going to support the whole "Figures linked to Image-of-a-Figure" workflow, then we have the whole structure for organising & browsing Figures, without having to build it again from scratch.

jstitlow commented 6 years ago

Thank you Mark!

will-moore commented 6 years ago

Unfortunately, with the way we now load thumbnails in bulk in webclient (and parade), the omero.client.browser.thumb_default_size won't be taken into account. But I'd be reluctant to suggest changing it anyway, since OMERO itself caches thumbnails at size 96 so trying to use a different size from the clients would hit performance. However, I understand the need for better resolution. A long time ago I played with the idea of loading a high-resolution thumbnail (full plane) when you clicked on an image https://www.youtube.com/watch?v=1ijH9cw2GsM - Loading the full plane is not a good idea for big images, but we could think about loading a larger thumbnail in some situations if this is important (and the Preview panel won't do)?