search

ome / napari-ome-zarr

A napari plugin for zarr backed OME-NGFF images
https://www.napari-hub.org/plugins/napari-ome-zarr
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

Tests fail with ome-zarr 0.8.3 #108

Open dstansby opened 1 month ago

dstansby commented 1 month ago

In https://github.com/ome/napari-ome-zarr/pull/107 I had to pin the version of ome-zarr to get the tests to pass; this should be fixed so napari-ome-zarr works with the latest version of ome-zarr. A quick glance at the diff between version 0.8.2 and 0.8.3 doesn't reveal anything obvious to me that would have broke the tests here...

dstansby commented 1 month ago

At a guess, ome/ome-zarr-py@c159b79 (#322) might be the culprit?

psobolewskiPhD commented 1 month ago

Interesting, I can use the plugin ok with ome-zarr 0.8.3, with napari 0.4.19. e.g. napari https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0001A/2551.zarr/A/1/0 Here's the validation: https://ome.github.io/ome-ngff-validator/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0001A/2551.zarr/A/1/0/

dstansby commented 1 month ago

CI at https://github.com/ome/napari-ome-zarr/pull/93 shows the issues with ome-zarr 0.8.3. I think it's with the reader, not the writer - were you testing the writing part of the plugin?

psobolewskiPhD commented 1 month ago

No, just reading.