Closed will-moore closed 2 years ago
Merging #32 (13d1c96) into main (08c3fa4) will increase coverage by
5.35%
. The diff coverage is71.42%
.
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 85.92% 91.28% +5.35%
==========================================
Files 3 3
Lines 199 195 -4
==========================================
+ Hits 171 178 +7
+ Misses 28 17 -11
Impacted Files | Coverage Δ | |
---|---|---|
napari_ome_zarr/_reader.py | 86.53% <71.42%> (+9.68%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 08c3fa4...13d1c96. Read the comment docs.
tested on M1 and everything is displayed
As discussed with @will-moore, the samples created for testing this PR raised additional questions outside the scope of this PR:
coordinateTransformations
defined at the multiscales
level rather than the datasets
level.Solving these issues will require some API thoughts across the various ome-zarr Python repositories. This should not block this from being merged as it allows to consume transformations introduced in the 0.4 version of the specification at the datasets level.
This uses the updated
coordinateTransformations
format forscale
andtranslate
, implemented in https://github.com/ome/ome-zarr-py/pull/162To test, using idr0101 where we have smaller images "cropped" from larger images, we can overlay them using the
translate
transformation. I have manually edited the13457537.zarr/.zattrs
and the/labels/0/.zattrs
to add translate, based on the rectangle 'crop' ROIs on the larger image.First, open the larger image in napari:
Then, in
napari
terminal, open the smaller one (also contains labels):Also: