Closed pre-commit-ci[bot] closed 2 years ago
Base: 92.43% // Head: 92.43% // No change to project coverage :thumbsup:
Coverage data is based on head (
71de889
) compared to base (1105df9
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
See https://github.com/globality-corp/flake8-logging-format/issues/35 Looks like there's a fix, but not release yet
@will-moore @joshmoore looks like the usage of f-strings and expr % variable
within logging statements is discouraged and now reported in the latest version of flake8
. A few repositories will need updated, with ome-zarr-py
making the biggest usage. d6b48bb0ceab49f198e9295c00a625a4a5fef0a5 proposes the corresponding fixed in the context of this repository. Leaving you to review and I can update the other repositories if we agree.
I find it sad that f-strings are apparently a no-no for logging but otherwise 🤷🏽
Closing in favor of gh-68.
updates: