ome / napari-ome-zarr

A napari plugin for zarr backed OME-NGFF images
https://www.napari-hub.org/plugins/napari-ome-zarr
BSD 3-Clause "New" or "Revised" License
27 stars 21 forks source link

[pre-commit.ci] pre-commit autoupdate #65

Closed pre-commit-ci[bot] closed 2 years ago

pre-commit-ci[bot] commented 2 years ago

updates:

codecov-commenter commented 2 years ago

Codecov Report

Base: 92.43% // Head: 92.43% // No change to project coverage :thumbsup:

Coverage data is based on head (71de889) compared to base (1105df9). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #65 +/- ## ======================================= Coverage 92.43% 92.43% ======================================= Files 3 3 Lines 185 185 ======================================= Hits 171 171 Misses 14 14 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ome). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ome)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

will-moore commented 2 years ago

See https://github.com/globality-corp/flake8-logging-format/issues/35 Looks like there's a fix, but not release yet

sbesson commented 2 years ago

@will-moore @joshmoore looks like the usage of f-strings and expr % variable within logging statements is discouraged and now reported in the latest version of flake8. A few repositories will need updated, with ome-zarr-py making the biggest usage. d6b48bb0ceab49f198e9295c00a625a4a5fef0a5 proposes the corresponding fixed in the context of this repository. Leaving you to review and I can update the other repositories if we agree.

joshmoore commented 2 years ago

I find it sad that f-strings are apparently a no-no for logging but otherwise 🤷🏽

joshmoore commented 2 years ago

Closing in favor of gh-68.