Review workflow: fix generated URL.

[sbesson]

As per https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target github.sha will point to the base branch SHA

[github-actions[bot]]

Automated Review URLs

• render latest/index.bs
• diff latest modified
• Debugging Info

  - github.sha: cf67f16e637bd4412363d0b918d1ef7cd54ec897 - github.event.pull_request: { "_links": { "comments": { "href": "https://api.github.com/repos/ome/ngff/issues/129/comments" }, "commits": { "href": "https://api.github.com/repos/ome/ngff/pulls/129/commits" }, "html": { "href": "https://github.com/ome/ngff/pull/129" }, "issue": { "href": "https://api.github.com/repos/ome/ngff/issues/129" }, "review_comment": { "href": "https://api.github.com/repos/ome/ngff/pulls/comments{/number}" }, "review_comments": { "href": "https://api.github.com/repos/ome/ngff/pulls/129/comments" }, "self": { "href": "https://api.github.com/repos/ome/ngff/pulls/129" }, "statuses": { "href": "https://api.github.com/repos/ome/ngff/statuses/41664d653b87029a18c8dc27e2bdf70205337c33" } }, "active_lock_reason": null, "additions": 0, "assignee": null, "assignees": [], "author_association": "MEMBER", "auto_merge": null, "base": { "label": "ome:main", "ref": "main", "repo": { "allow_auto_merge": false, "allow_forking": true, "allow_merge_commit": true, "allow_rebase_merge": true, "allow_squash_merge": true, "allow_update_branch": false, "archive_url": "https://api.github.com/repos/ome/ngff/{archive_format}{/ref}", "archived": false, "assignees_url": "https://api.github.com/repos/ome/ngff/assignees{/user}", "blobs_url": "https://api.github.com/repos/ome/ngff/git/blobs{/sha}", "branches_url": "https://api.github.com/repos/ome/ngff/branches{/branch}", "clone_url": "https://github.com/ome/ngff.git", "collaborators_url": "https://api.github.com/repos/ome/ngff/collaborators{/collaborator}", "comments_url": "https://api.github.com/repos/ome/ngff/comments{/number}", "commits_url": "https://api.github.com/repos/ome/ngff/commits{/sha}", "compare_url": "https://api.github.com/repos/ome/ngff/compare/{base}...{head}", "contents_url": "https://api.github.com/repos/ome/ngff/contents/{+path}", "contributors_url": "https://api.github.com/repos/ome/ngff/contributors", "created_at": "2020-11-17T14:55:39Z", "default_branch": "main", "delete_branch_on_merge": false, "deployments_url": "https://api.github.com/repos/ome/ngff/deployments", "description": "Next-generation file format (NGFF) specifications for storing bioimaging data in the cloud.", "disabled": false, "downloads_url": "https://api.github.com/repos/ome/ngff/downloads", "events_url": "https://api.github.com/repos/ome/ngff/events", "fork": false, "forks": 16, "forks_count": 16, "forks_url": "https://api.github.com/repos/ome/ngff/forks", "full_name": "ome/ngff", "git_commits_url": "https://api.github.com/repos/ome/ngff/git/commits{/sha}", "git_refs_url": "https://api.github.com/repos/ome/ngff/git/refs{/sha}", "git_tags_url": "https://api.github.com/repos/ome/ngff/git/tags{/sha}", "git_url": "git://github.com/ome/ngff.git", "has_downloads": true, "has_issues": true, "has_pages": true, "has_projects": true, "has_wiki": true, "homepage": "https://ngff.openmicroscopy.org", "hooks_url": "https://api.github.com/repos/ome/ngff/hooks", "html_url": "https://github.com/ome/ngff", "id": 313652456, "is_template": false, "issue_comment_url": "https://api.github.com/repos/ome/ngff/issues/comments{/number}", "issue_events_url": "https://api.github.com/repos/ome/ngff/issues/events{/number}", "issues_url": "https://api.github.com/repos/ome/ngff/issues{/number}", "keys_url": "https://api.github.com/repos/ome/ngff/keys{/key_id}", "labels_url": "https://api.github.com/repos/ome/ngff/labels{/name}", "language": "Python", "languages_url": "https://api.github.com/repos/ome/ngff/languages", "license": { "key": "other", "name": "Other", "node_id": "MDc6TGljZW5zZTA=", "spdx_id": "NOASSERTION", "url": null }, "merges_url": "https://api.github.com/repos/ome/ngff/merges", "milestones_url": "https://api.github.com/repos/ome/ngff/milestones{/number}", "mirror_url": null, "name": "ngff", "node_id": "MDEwOlJlcG9zaXRvcnkzMTM2NTI0NTY=", "notifications_url": "https://api.github.com/repos/ome/ngff/notifications{?since,all,participating}", "open_issues": 58, "open_issues_count": 58, "owner": { "avatar_url": "https://avatars.githubusercontent.com/u/1831717?v=4", "events_url": "https://api.github.com/users/ome/events{/privacy}", "followers_url": "https://api.github.com/users/ome/followers", "following_url": "https://api.github.com/users/ome/following{/other_user}", "gists_url": "https://api.github.com/users/ome/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ome", "id": 1831717, "login": "ome", "node_id": "MDEyOk9yZ2FuaXphdGlvbjE4MzE3MTc=", "organizations_url": "https://api.github.com/users/ome/orgs", "received_events_url": "https://api.github.com/users/ome/received_events", "repos_url": "https://api.github.com/users/ome/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ome/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ome/subscriptions", "type": "Organization", "url": "https://api.github.com/users/ome" }, "private": false, "pulls_url": "https://api.github.com/repos/ome/ngff/pulls{/number}", "pushed_at": "2022-05-30T13:24:23Z", "releases_url": "https://api.github.com/repos/ome/ngff/releases{/id}", "size": 578, "ssh_url": "git@github.com:ome/ngff.git", "stargazers_count": 61, "stargazers_url": "https://api.github.com/repos/ome/ngff/stargazers", "statuses_url": "https://api.github.com/repos/ome/ngff/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/ome/ngff/subscribers", "subscription_url": "https://api.github.com/repos/ome/ngff/subscription", "svn_url": "https://github.com/ome/ngff", "tags_url": "https://api.github.com/repos/ome/ngff/tags", "teams_url": "https://api.github.com/repos/ome/ngff/teams", "topics": [ "bioimaging", "cloud", "data-science", "file-formats", "spec" ], "trees_url": "https://api.github.com/repos/ome/ngff/git/trees{/sha}", "updated_at": "2022-05-29T16:13:22Z", "url": "https://api.github.com/repos/ome/ngff", "visibility": "public", "watchers": 61, "watchers_count": 61 }, "sha": "cf67f16e637bd4412363d0b918d1ef7cd54ec897", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1831717?v=4", "events_url": "https://api.github.com/users/ome/events{/privacy}", "followers_url": "https://api.github.com/users/ome/followers", "following_url": "https://api.github.com/users/ome/following{/other_user}", "gists_url": "https://api.github.com/users/ome/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ome", "id": 1831717, "login": "ome", "node_id": "MDEyOk9yZ2FuaXphdGlvbjE4MzE3MTc=", "organizations_url": "https://api.github.com/users/ome/orgs", "received_events_url": "https://api.github.com/users/ome/received_events", "repos_url": "https://api.github.com/users/ome/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ome/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ome/subscriptions", "type": "Organization", "url": "https://api.github.com/users/ome" } }, "body": "As per https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target\r\ngithub.sha will point to the base branch SHA", "changed_files": 0, "closed_at": null, "comments": 6, "comments_url": "https://api.github.com/repos/ome/ngff/issues/129/comments", "commits": 5, "commits_url": "https://api.github.com/repos/ome/ngff/pulls/129/commits", "created_at": "2022-05-30T11:19:31Z", "deletions": 0, "diff_url": "https://github.com/ome/ngff/pull/129.diff", "draft": false, "head": { "label": "sbesson:review_sha", "ref": "review_sha", "repo": { "allow_auto_merge": false, "allow_forking": true, "allow_merge_commit": true, "allow_rebase_merge": true, "allow_squash_merge": true, "allow_update_branch": false, "archive_url": "https://api.github.com/repos/sbesson/ngff/{archive_format}{/ref}", "archived": false, "assignees_url": "https://api.github.com/repos/sbesson/ngff/assignees{/user}", "blobs_url": "https://api.github.com/repos/sbesson/ngff/git/blobs{/sha}", "branches_url": "https://api.github.com/repos/sbesson/ngff/branches{/branch}", "clone_url": "https://github.com/sbesson/ngff.git", "collaborators_url": "https://api.github.com/repos/sbesson/ngff/collaborators{/collaborator}", "comments_url": "https://api.github.com/repos/sbesson/ngff/comments{/number}", "commits_url": "https://api.github.com/repos/sbesson/ngff/commits{/sha}", "compare_url": "https://api.github.com/repos/sbesson/ngff/compare/{base}...{head}", "contents_url": "https://api.github.com/repos/sbesson/ngff/contents/{+path}", "contributors_url": "https://api.github.com/repos/sbesson/ngff/contributors", "created_at": "2020-11-25T08:48:58Z", "default_branch": "main", "delete_branch_on_merge": false, "deployments_url": "https://api.github.com/repos/sbesson/ngff/deployments", "description": "Next-generation file format (NGFF) specifications for storing bioimaging data in the cloud.", "disabled": false, "downloads_url": "https://api.github.com/repos/sbesson/ngff/downloads", "events_url": "https://api.github.com/repos/sbesson/ngff/events", "fork": true, "forks": 0, "forks_count": 0, "forks_url": "https://api.github.com/repos/sbesson/ngff/forks", "full_name": "sbesson/ngff", "git_commits_url": "https://api.github.com/repos/sbesson/ngff/git/commits{/sha}", "git_refs_url": "https://api.github.com/repos/sbesson/ngff/git/refs{/sha}", "git_tags_url": "https://api.github.com/repos/sbesson/ngff/git/tags{/sha}", "git_url": "git://github.com/sbesson/ngff.git", "has_downloads": true, "has_issues": false, "has_pages": true, "has_projects": true, "has_wiki": true, "homepage": "https://ngff.openmicroscopy.org", "hooks_url": "https://api.github.com/repos/sbesson/ngff/hooks", "html_url": "https://github.com/sbesson/ngff", "id": 315879947, "is_template": false, "issue_comment_url": "https://api.github.com/repos/sbesson/ngff/issues/comments{/number}", "issue_events_url": "https://api.github.com/repos/sbesson/ngff/issues/events{/number}", "issues_url": "https://api.github.com/repos/sbesson/ngff/issues{/number}", "keys_url": "https://api.github.com/repos/sbesson/ngff/keys{/key_id}", "labels_url": "https://api.github.com/repos/sbesson/ngff/labels{/name}", "language": "Python", "languages_url": "https://api.github.com/repos/sbesson/ngff/languages", "license": { "key": "other", "name": "Other", "node_id": "MDc6TGljZW5zZTA=", "spdx_id": "NOASSERTION", "url": null }, "merges_url": "https://api.github.com/repos/sbesson/ngff/merges", "milestones_url": "https://api.github.com/repos/sbesson/ngff/milestones{/number}", "mirror_url": null, "name": "ngff", "node_id": "MDEwOlJlcG9zaXRvcnkzMTU4Nzk5NDc=", "notifications_url": "https://api.github.com/repos/sbesson/ngff/notifications{?since,all,participating}", "open_issues": 0, "open_issues_count": 0, "owner": { "avatar_url": "https://avatars.githubusercontent.com/u/1355463?v=4", "events_url": "https://api.github.com/users/sbesson/events{/privacy}", "followers_url": "https://api.github.com/users/sbesson/followers", "following_url": "https://api.github.com/users/sbesson/following{/other_user}", "gists_url": "https://api.github.com/users/sbesson/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sbesson", "id": 1355463, "login": "sbesson", "node_id": "MDQ6VXNlcjEzNTU0NjM=", "organizations_url": "https://api.github.com/users/sbesson/orgs", "received_events_url": "https://api.github.com/users/sbesson/received_events", "repos_url": "https://api.github.com/users/sbesson/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sbesson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sbesson/subscriptions", "type": "User", "url": "https://api.github.com/users/sbesson" }, "private": false, "pulls_url": "https://api.github.com/repos/sbesson/ngff/pulls{/number}", "pushed_at": "2022-05-30T13:24:38Z", "releases_url": "https://api.github.com/repos/sbesson/ngff/releases{/id}", "size": 518, "ssh_url": "git@github.com:sbesson/ngff.git", "stargazers_count": 1, "stargazers_url": "https://api.github.com/repos/sbesson/ngff/stargazers", "statuses_url": "https://api.github.com/repos/sbesson/ngff/statuses/{sha}", "subscribers_url": "https://api.github.com/repos/sbesson/ngff/subscribers", "subscription_url": "https://api.github.com/repos/sbesson/ngff/subscription", "svn_url": "https://github.com/sbesson/ngff", "tags_url": "https://api.github.com/repos/sbesson/ngff/tags", "teams_url": "https://api.github.com/repos/sbesson/ngff/teams", "topics": [], "trees_url": "https://api.github.com/repos/sbesson/ngff/git/trees{/sha}", "updated_at": "2022-02-02T17:24:11Z", "url": "https://api.github.com/repos/sbesson/ngff", "visibility": "public", "watchers": 1, "watchers_count": 1 }, "sha": "41664d653b87029a18c8dc27e2bdf70205337c33", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1355463?v=4", "events_url": "https://api.github.com/users/sbesson/events{/privacy}", "followers_url": "https://api.github.com/users/sbesson/followers", "following_url": "https://api.github.com/users/sbesson/following{/other_user}", "gists_url": "https://api.github.com/users/sbesson/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sbesson", "id": 1355463, "login": "sbesson", "node_id": "MDQ6VXNlcjEzNTU0NjM=", "organizations_url": "https://api.github.com/users/sbesson/orgs", "received_events_url": "https://api.github.com/users/sbesson/received_events", "repos_url": "https://api.github.com/users/sbesson/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sbesson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sbesson/subscriptions", "type": "User", "url": "https://api.github.com/users/sbesson" } }, "html_url": "https://github.com/ome/ngff/pull/129", "id": 950861662, "issue_url": "https://api.github.com/repos/ome/ngff/issues/129", "labels": [], "locked": false, "maintainer_can_modify": true, "merge_commit_sha": "64b47aa8c74147a7b5feac07ba850e37c40599da", "mergeable": null, "mergeable_state": "unknown", "merged": false, "merged_at": null, "merged_by": null, "milestone": null, "node_id": "PR_kwDOErH06M44rP9e", "number": 129, "patch_url": "https://github.com/ome/ngff/pull/129.patch", "rebaseable": null, "requested_reviewers": [], "requested_teams": [], "review_comment_url": "https://api.github.com/repos/ome/ngff/pulls/comments{/number}", "review_comments": 0, "review_comments_url": "https://api.github.com/repos/ome/ngff/pulls/129/comments", "state": "open", "statuses_url": "https://api.github.com/repos/ome/ngff/statuses/41664d653b87029a18c8dc27e2bdf70205337c33", "title": "Review workflow: fix generated URL.", "updated_at": "2022-05-30T13:24:39Z", "url": "https://api.github.com/repos/ome/ngff/pulls/129", "user": { "avatar_url": "https://avatars.githubusercontent.com/u/1355463?v=4", "events_url": "https://api.github.com/users/sbesson/events{/privacy}", "followers_url": "https://api.github.com/users/sbesson/followers", "following_url": "https://api.github.com/users/sbesson/following{/other_user}", "gists_url": "https://api.github.com/users/sbesson/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sbesson", "id": 1355463, "login": "sbesson", "node_id": "MDQ6VXNlcjEzNTU0NjM=", "organizations_url": "https://api.github.com/users/sbesson/orgs", "received_events_url": "https://api.github.com/users/sbesson/received_events", "repos_url": "https://api.github.com/users/sbesson/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sbesson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sbesson/subscriptions", "type": "User", "url": "https://api.github.com/users/sbesson" } } - github.head.ref:

[joshmoore]

Just doing this to but I don't think a pull_request_target PR will likely not let you appropriately test. That was my problem with the previous attempts.

But I'll leave you to investigate.

[sbesson]

Just doing this to but I don't think a pull_request_target PR will likely not let you appropriately test.

Ah now I get the "This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does.". Yes not sure how to test this now

[joshmoore]

~Shall we reopen my origin/review branch, push your commit there, and open PRs against it?~

Edit: actually that probably won't work either. Maybe it's just pushes to main.

[joshmoore]

I'll move this to origin/main and revert if necessary.

[joshmoore]

After pushing head.ref this has been updated, but that doesn't resolve, since ome/ngff/review_sha doesn't exist. I'll try to find an explicit sha for the PR.