search

ome / ngff

Next-generation file format (NGFF) specifications for storing bioimaging data in the cloud.
https://ngff.openmicroscopy.org
Other
119 stars 41 forks source link

Clarify `version` field #210

Open d-v-b opened 1 year ago

d-v-b commented 1 year ago

For the various metadata objects with a version field, this PR makes explicit that version is a string, and that it must be the current version.

github-actions[bot] commented 1 year ago

Automated Review URLs

normanrz commented 1 year ago

I wonder if you'd want to integrate that with https://github.com/ome/ngff/pull/206?

d-v-b commented 1 year ago

Definitely. I see that you are building on #138 -- is there a timeline for getting that finalized (it's been nearly a year)?

joshmoore commented 1 year ago

is there a timeline for getting that finalized (it's been nearly a year)?

Let's not start that discussion on this thread. Unless there's a major change in priorities, the next major version (0.5) would include transforms and so it makes sense for @normanrz to be building on top of it since the bump to Zarr v3 will need to be its own major version. If you'd still like to target this earlier then I'd suggest not building on top of #206, but :+1: for having them work together to prevent unnecessary churn.

d-v-b commented 1 year ago

I think the changes here are essentially a patch to the latest version of the spec? So I'm not sure what I should build off other than main?

joshmoore commented 1 year ago

Agreed.