search

ome / ome-codecs

OME image compression (coder-decoder implementations)
Other
4 stars 13 forks source link

MJPB: fix Huffman table handling for images with multiple components #8

Closed melissalinkert closed 6 years ago

melissalinkert commented 7 years ago

Fixes https://trac.openmicroscopy.org/ome/ticket/4087

This definitely isn't an urgent/critical fix, more an excuse to close a very old ticket.

The easiest way to test is likely to switch a local build of Bio-Formats to use 0.2.1-SNAPSHOT and compare the results of showinf on data_repo/curated/quicktime/mjpb/*.mov with and without this PR included in the snapshot build. The PDF file in the same directory is a screenshot for verification.

I'm not completely clear on the expected workflow for reviewing PRs in this repo though, so happy to discuss.

sbesson commented 6 years ago

Very late review, apologies. As expected, the integration of this PR in coupled builds causes a few failures against the existing quicktime samples - https://web-proxy.openmicroscopy.org/east-ci/job/BIOFORMATS-test-folder/28949/console. If all these failures are expected then we might only need a configuration PR updating the pixel hashes as expected by the PR description.

melissalinkert commented 6 years ago

Those failures should be expected - is it better to open the configuration PR against east for now?

sbesson commented 6 years ago

Yes, let's use east for the time being if that's okay with you. We can update branches for inclusion e.g. in 5.9.x in a second step

melissalinkert commented 6 years ago

https://github.com/openmicroscopy/data_repo_config/pull/316 opened, but as noted an additional commit to add alternate MD5s may be needed if there are still test failures.

sbesson commented 6 years ago

Successfully tested with the sample dataset. Merging and I will cut a patch release of ome-codecs that can be bumped in bioformats.

sbesson commented 6 years ago

org.openmicroscopy:ome-codecs:0.2.3 was just released to Central and should appear under http://repo1.maven.org/maven2/org/openmicroscopy/ome-codecs/ in the upcoming hours. Next step is to open a PR against https://github.com/openmicroscopy/bioformats to bump the version and the ticket can be closed.