ome / ome-model

OME model (specification, code generator, implementation)
Other
13 stars 26 forks source link

Add support for Creator attribute in ome.xml.meta classes #103

Closed sbesson closed 4 years ago

sbesson commented 4 years ago

Initially reported by and discussed with @ngladitz over IRC

The generated OME model classes have currently only partial support for the OME.Creator attribute of the OME 2016-06 schema. More precisely

From the Bio-Formats consumer perspective, this means that the Creator metadata is currently lost while running MetadataConverter.

Unless there is a clear rationale for excluding the Creator attribute, it feels like we want to (re)add support in the metadata classes. Assuming the top-level OME element is not completely handled by the code generation, a starting point would be to add methods to the list of manual definitions e.g. https://github.com/ome/ome-model/blob/v6.0.1/xsd-fu/templates-java/MetadataRetrieve.template#L348. As an additional technical point, it would be very useful to find a way and make such additions amenable to a minor release increment (backwards-compatible API addition) rather than a major release increment (breaking API).

sbesson commented 4 years ago

Closing as per #108