search

ome / ome-model

OME model (specification, code generator, implementation)
Other
13 stars 26 forks source link

OME-XML: Update python in pom to python3 #106

Closed dgault closed 4 years ago

dgault commented 4 years ago

This is a supplementary PR to https://github.com/ome/ome-model/pull/105 and should fix the broken build as seen in https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-build/jdk=JDK8,label=testintegration/248/console

rleigh-codelibre commented 4 years ago

Hi David,

Just one point to note, that this isn't strictly portable. The most robust solution would be to override the property on the command line.

While python3 is often present, it's not universally true. It's not true in virtualenvs on several platforms. And it also won't be true after python2 is fully dropped and systems make python invoke python3 there as well.

So it's fine to swap, but it will break as much the other way around as it does the current way around, but that will become less likely over time.

Regards, Roger

joshmoore commented 4 years ago

e.g. https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-image/274/console

I've opened https://github.com/ome/bio-formats-build/pull/73 as a temporary fix. An alternative would be to take a parameter in the Dockerfile itself then Jenkins could pass through a variable.

rleigh-codelibre commented 4 years ago

@dgault @joshmoore You might find this of interest:

machines.yml -- look at the various PYTHON_EXECUTABLE variants; this demonstrates the variance between python and python3 on various platforms.

We then run gradle with "-Ppython=$PYTHON_EXECUTABLE"; the equivalent can be done with maven. With the above setup, PYTHON_EXECUTABLE is a machine/platform-specific property so the jobs themselves are platform-agnostic; example.

sbesson commented 4 years ago

--exclude see https://github.com/ome/bio-formats-build/pull/79