search

ome / ome-model

OME model (specification, code generator, implementation)
Other
13 stars 26 forks source link

Ensure stdout works in Jupyter Notebooks #121

Closed manics closed 4 years ago

manics commented 4 years ago

sys.stdout in Jupyter notebooks may not have a buffer attribute.

To test: run create_companion(images=[companion]) (i.e. use the default out parameter) in a Jupyter Notebook.

See e.g. https://github.com/Yelp/mrjob/pull/1443

manics commented 4 years ago

For testing you can use nbval, for example https://github.com/IDR/idr-notebooks/blob/master/docker/test_notebooks.sh though note this script isn't yet automatically run in travis on that repo.