search

ome / ome-model

OME model (specification, code generator, implementation)
Other
13 stars 26 forks source link

Python 3.9 requires Genshi update #126

Closed rleigh-codelibre closed 3 years ago

rleigh-codelibre commented 3 years ago

Due to changes in the language, the vendored Genshi dependency will require an update. Support is currently being developed upstream, and a new release is expected reasonably soon.

rleigh-codelibre commented 3 years ago

I've got generation working with Python 3.9 in this merge request and pipeline. No code generation differences.

A few issues found with Genshi which have been pushed upstream. That's still being investigated and reviewed.

Depending upon how urgently you want Python 3.9 support, I could open a pull request with the ome-model updates I tested and merged on GitLab. Or you can wait until the fixes are merged upstream and then take the new upstream Genshi.

sbesson commented 3 years ago

Hi @rleigh-codelibre, thanks for the heads-up and all the preliminary work on the Python compatibility of Genshi.

From our side, there is no driver or urgent need to support Python 3.9 at the moment. If the expectations is that the changes should make it into an upstream Genshi release, our preference would be to consume the official package and drop the patched Genshi copy in this repository by the same occasion. We will track the progress of your contribution to the Genshi repository and we can revisit this in a few months if necessary

rleigh-codelibre commented 3 years ago

OK. Do bear in mind that the reason we aren't using the upstream directly is because it has historically been subject to frequent breakage, otherwise we would just have installed it directly with pip. And as you can see, Python 3.9 is not an exception to this rule! So you may still want to include it directly to avoid random breakage. Hopefully there will be a tagged release which will be usable for ome-model sometime soon, and that will likely be the optimal point to pick up a fresh copy.