ome / ome-model

OME model (specification, code generator, implementation)
Other
13 stars 26 forks source link

ome-xml: java: Don't report unhandled links prematurely #128

Closed rleigh-codelibre closed 1 year ago

rleigh-codelibre commented 3 years ago

This PR is a second version of #81 but is Java-only and omits the C++ changes which are no longer applicable. Please also see the discussion on that PR.

This PR corrects some long-standing issues in the Java reference processing implementation.

In effect, you will see that setting an AnnotationRef on Detector or any other element derived from ManufacturerSpec will no longer have ManufacturerSpec::link issue a bogus warning. This applies to any model object which is derived from another model object, e.g. LightSource, where the reference is handled by the most derived type, or any derived type after the first, where the chaining up will trigger the spurious warning.

For OMERO import, this should remove a large number of the bogus import warnings related to OME-XML metadata which we have seen on e.g. the QA system and other channels over the last few years. LightSource and Shape are notable culprits.

Testing:

rleigh-codelibre commented 3 years ago

Rebased to run with GitHub Actions.