search

ome / ome-model

OME model (specification, code generator, implementation)
Other
13 stars 26 forks source link

MetadataConverter: Fix dropping of WellAnnotationRefs during conversion #131

Closed rleigh-codelibre closed 3 years ago

rleigh-codelibre commented 3 years ago

Correctly initialise wellAnnotationRefCount.

This defect was found during static analysis of the source tree. I will have several additional fixes to come, plus a number of performance and cosmetic improvements also picked up by the static analyser.

Testing: Try converting an OME-TIFF with WellAnnotationRefs. You should see that they are stripped out during conversion. Repeat with this PR. You should find they are now correctly preserved.

Closes: #130

imagesc-bot commented 3 years ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/static-analysis-and-ome-model-bugfixes/45977/1

imagesc-bot commented 3 years ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/static-analysis-and-ome-model-bugfixes/45977/2

rleigh-codelibre commented 3 years ago

Rebased to run with GitHub Actions.