ome / ome-model

OME model (specification, code generator, implementation)
Other
13 stars 26 forks source link

OMEXMLModelEnumHandler template: Correct type evaluation order #133

Closed rleigh-codelibre closed 1 year ago

rleigh-codelibre commented 3 years ago

Closes: #132

Testing: You will need to check which type each primitive type extends and confirm that the ordering is from most-derived to least-derived so that all types are correctly processed. You could alternatively run a static analyser on the generated sources to confirm that none of the conditional blocks are unreachable (which is how the defect was originally found).

Generated source changes: Download the diff from here or generate the diff yourself.

imagesc-bot commented 3 years ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/static-analysis-and-ome-model-bugfixes/45977/1

rleigh-codelibre commented 3 years ago

Rebased to run with GitHub Actions.