search

ome / ome-model

OME model (specification, code generator, implementation)
Other
13 stars 26 forks source link

OMEXMLModelEnum template: Correct exception handling #134

Closed rleigh-codelibre closed 1 year ago

rleigh-codelibre commented 3 years ago

Static analysis highlighted a bad use of return within a finally block. This was indeed unnecessary and replaceable with an ignored catch block.

Testing: Nothing specific required; the effective code flow is unchanged with or without exceptions, but we no longer return from within a finally block.

Generated source changes: Download the diff from here or generate the diff yourself.

imagesc-bot commented 3 years ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/static-analysis-and-ome-model-bugfixes/45977/1

rleigh-codelibre commented 3 years ago

Rebased to run with GitHub Actions.