search

ome / ome-model

OME model (specification, code generator, implementation)
Other
13 stars 25 forks source link

2008-09 to 2009-09: Move CustomAttributes transforms to top level #144

Closed dgault closed 3 years ago

dgault commented 3 years ago

This is a follow up to https://github.com/ome/ome-model/issues/142 and should see the unit tests in https://github.com/ome/bioformats/pull/3695 turn green.

The issue appears to have been due to CustomAttributes being able to be located in 4 different locations:

The non top level CustomAttributes were being transformed into XMLAnnotations but embedded in the original element, be it Image or Dataset, this is an invalid location for it and thus it was not being recognised when converted back to an OME-Model object. This PR aims to move all CustomAnnotations to the top OME level before transforming them. If you have multiple CustomAttributes at different levels then you will get multiple XMLAnnotations inside a single StructuredAnnotations.

Fixes https://github.com/ome/ome-model/issues/142

sbesson commented 3 years ago

@dgault looks like this PR has been opened from a branch on the ome/ome-model repository itself. Unfortunately, while Travis has been disabled for Pull Requests, there was a remaining webhook that created a failing build on the push event which will I cannot easily remove.

Could you either force push or recreate a PR from your fork?