search

ome / ome-model

OME model (specification, code generator, implementation)
Other
13 stars 26 forks source link

xsd-fu: Aggregate generated C++ source files into single source files for model and enums #79

Closed rleigh-codelibre closed 6 years ago

rleigh-codelibre commented 6 years ago

This significantly reduces compile times (up to 30 minutes!). Check out the build time trend graphs in jenkins for the various matrix combinations. The source files for the model and enums are concatenated into single source files so >100 compiler invocations are reduced to two. No C++ code changes, or any changes to the generated Java code. Headers are still individual, so from the user's point of view there is zero change.

This can go into the next patch release or minor release (there are no code changes, so either is fine).

Testing: Check builds are green.

rleigh-codelibre commented 6 years ago

For build time trend examples, see:

maxquant is ~2 mins saved only (due to the huge core count and parallel build)

rleigh-codelibre commented 6 years ago

Green in:

dgault commented 6 years ago

The builds are certainly reduced in time and the generated files from the build appear unaffected. This doesn't look like it would have any impact on end users so should be safe to merge.