ome / ome-model

OME model (specification, code generator, implementation)
Other
13 stars 26 forks source link

Expand experimental model library to generate SPW samples #92

Closed sbesson closed 5 years ago

sbesson commented 5 years ago

See http://lists.openmicroscopy.org.uk/pipermail/ome-users/2018-November/007281.html

This builds on top of #91 to create companion OME-XML for SPW use cases.

joshmoore commented 5 years ago

Can it still create image XML? Perhaps this should be plate.companion() and image.companion().

sbesson commented 5 years ago

:) I was debating between create_{plate,image}_companion or create_companion(plate=plate, images=images) but I like the idea of Object.companion(). In that case, would plate.companion() traverse the whole graph or does it stop at ImageRef and individual image.companion need to be invoked?

joshmoore commented 5 years ago

The latter sounds complicated. I'm fine with either of the first two signatures to start with, but I definitely need to be able to generate non SPW images.

joshmoore commented 5 years ago

This has been raised again by the SpaceTx crew. Do you want to get this into the first release? or shall I push the previous version to PyPI?

sbesson commented 5 years ago

If that is useful for others to consume, I can definitely see getting this integrated and pushed to PyPi. For 6 pre-releases, this is is where the semver vs PEP440 incompatiblity might be tricky to handle - maybe 6.0.0a1 ?

joshmoore commented 5 years ago

Merging and looking into publishing.

joshmoore commented 5 years ago

https://pypi.org/project/ome-model/6.0.0a1/ -- note: alpha version downloads without --pre as the only version.