ome / ome-ngff-validator

Web page for validating OME-NGFF files
https://ome.github.io/ome-ngff-validator
BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Fix links with pathname #12

Closed will-moore closed 2 years ago

will-moore commented 2 years ago

Bug-fix: Clicking on Wells e.g. https://ome.github.io/ome-ngff-validator/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0001A/2551.zarr/ gives a 404 since the URL doesn't include the window.location.pathname. This isn't needed when deployed on a dev-server (during development) or on netlify (PR preview) but on github pages, it IS. The window.location.pathname is /ome-ngff-validator/ (e.g. enter window.location.pathname into the dev console at the above URL) and this is missing from the URLs to Wells.

So, this PR should fix the deployment above, but can't really be tested on the PR preview (although it will still work since window.location.pathname is / on the netlify deploy).

NB: Updated Changelog with this as 0.2.1

netlify[bot] commented 2 years ago

Deploy Preview for ome-ngff-validator ready!

Name Link
Latest commit e809d017df6f8cda3d2cd0f81fb39fd152465d4b
Latest deploy log https://app.netlify.com/sites/ome-ngff-validator/deploys/62da7c794233a800093e2067
Deploy Preview https://deploy-preview-12--ome-ngff-validator.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pwalczysko commented 2 years ago

The code change makes sense. As far as I understand, the PR is not testable before merge and deploy.

Maybe we should merge and see if the behaviour in the deployment stops showing the bug (?) cc @joshmoore

joshmoore commented 2 years ago

Sounds fine to me. Merging. (Does that mean proactive release as well?)

will-moore commented 2 years ago

Yey, https://ome.github.io/ome-ngff-validator/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0001A/2551.zarr/ links are fixed! Thanks!

joshmoore commented 2 years ago

:+1: