ome / ome-ngff-validator

Web page for validating OME-NGFF files
https://ome.github.io/ome-ngff-validator
BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Bioformats layout #13

Closed will-moore closed 1 year ago

will-moore commented 2 years ago

For a bioformats2raw.layout, load the OME/METADATA.xml and show image names, with links to browse to them.

WIP:

Screenshot 2022-09-09 at 17 19 58

netlify[bot] commented 2 years ago

Deploy Preview for ome-ngff-validator ready!

Name Link
Latest commit 9a4d3a99066e12fcaf7754ed867cf90689d78966
Latest deploy log https://app.netlify.com/sites/ome-ngff-validator/deploys/63341a1760e9af000934ad1a
Deploy Preview https://deploy-preview-13--ome-ngff-validator.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

joshmoore commented 1 year ago

https://deploy-preview-13--ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/test-data/bf2raw/fake-series-2.zarr results in:

Loading metadata: /OME/METADATA.ome.xml Error loading https://uk1s3.embassy.ebi.ac.uk/idr/zarr/test-data/bf2raw/fake-series-2.zarr//OME/METADATA.ome.xml: Not Found

due to the extra slash (//)

https://deploy-preview-13--ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/test-data/bf2raw/plate-rows-2.zarr stops at "loading..."

will-moore commented 1 year ago

@joshmoore Fixed links (and I ignore Bioformats2raw layout for plates). Also, added a vizarr link to each Image

Screenshot 2022-09-15 at 13 14 39

joshmoore commented 1 year ago

Also, added a vizarr link to each Image

That's a good idea for working around https://github.com/hms-dbmi/vizarr/issues/149 :+1:

joshmoore commented 1 year ago

Any other changes expected here, @will-moore ?

will-moore commented 1 year ago

No, I'm not planning to add anything else

joshmoore commented 1 year ago

Propose to release tomorrow as 0.3.0 along with https://github.com/ome/ngff/pull/112#pullrequestreview-1120170007

will-moore commented 1 year ago

@joshmoore I updated version to 0.3.0 and updated changelog

imagesc-bot commented 1 year ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/intermission-ome-ngff-0-4-1-bioformats2raw-0-5-0-et-al/72214/1

will-moore commented 1 year ago

@joshmoore it looks like something's gone wrong with the deploy as https://ome.github.io/ome-ngff-validator/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.3/9836842.zarr is not showing this PR. The netlify build is OK https://ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.3/9836842.zarr but deploy to gh-pages isn't?

Will look more tomorrow....

joshmoore commented 1 year ago

Think it's just missing the tag. I'll add one now.

joshmoore commented 1 year ago

I take it back. That didn't trigger anything additional; it does look like the deployments just didn't run...

joshmoore commented 1 year ago

Your merge here looks to have triggered the gh-pages branch to be updated:

https://github.com/ome/ome-ngff-validator/tree/gh-pages

but that didn't trigger a job for some reason.