ome / ome-ngff-validator

Web page for validating OME-NGFF files
https://ome.github.io/ome-ngff-validator
BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Fix versions for dtype checks. Don't check v0.4 #18

Closed will-moore closed 10 months ago

will-moore commented 1 year ago

My bad: For https://github.com/ome/ome-ngff-validator/pull/16#issuecomment-1297636546 the validator checks dtypes for v0.4 NGFF and asserts failure if dtypes mismatch (so that the PR could be tested). However, v0.4 NGFF with mismatching dtypes are not actually invalid. I forgot to revert that change before merging. So this PR fixes that and ONLY asserts that mismatching dtypes are invalid for versions after v0.4, to correspond to https://github.com/ome/ngff/pull/154

So, checking the mismatching dytpe sample from the PR above (v0.4) should no-longer give a warning: https://deploy-preview-18--ome-ngff-validator.netlify.app/?source=https://minio-dev.openmicroscopy.org/idr/v0.4/idr0077/9836832_z.zarr

netlify[bot] commented 1 year ago

Deploy Preview for ome-ngff-validator ready!

Name Link
Latest commit 4acfaaa528b1e8be09711e2adb8501a6ad5c5952
Latest deploy log https://app.netlify.com/sites/ome-ngff-validator/deploys/6537e31657d9200007082b46
Deploy Preview https://deploy-preview-18--ome-ngff-validator.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

joshmoore commented 10 months ago

Thanks, @will-moore. MSTM.

I assume it's considerably more work, but do you think it would be possible to get an informational message that this would cause an error/warning in the next version?

will-moore commented 10 months ago

@joshmoore https://deploy-preview-18--ome-ngff-validator.netlify.app/?source=https://minio-dev.openmicroscopy.org/idr/v0.4/idr0077/9836832_z.zarr

It will look like this with Error for versions 0.5+: Screenshot 2023-10-24 at 16 23 18

But for versions 0.1 - 0.4 you'll just see it as a warning: Screenshot 2023-10-24 at 16 29 42

joshmoore commented 10 months ago

Wow, nice!