Closed will-moore closed 1 year ago
Name | Link |
---|---|
Latest commit | 66af69f95d922b0789d7b0407c6cd63617a84d1e |
Latest deploy log | https://app.netlify.com/sites/ome-ngff-validator/deploys/63f35a43c4b7c30008eded48 |
Deploy Preview | https://deploy-preview-27--ome-ngff-validator.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@joshmoore I think that should fix production deployment.
The icons are working in the deploy preview (above) but they also did before (in the previous PR preview at https://deploy-preview-23--ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0062A/6001240.zarr)
The difference you can see is in that case, you have <img class="viewer_icon svelte-19lakda" src="/vizarr_logo.png" alt="Viewer logo">
whereas in the preview above you have <img class="viewer_icon svelte-ymmonc" src="https://deploy-preview-27--ome-ngff-validator.netlify.app/vizarr_logo.png" alt="Viewer logo">
which should translate into the correct absolute URLs in production.
I'm not sure how to reliably test (which is probably also an issue). Merging since the current production version is broken and I'll re-test there.
No luck, @will-moore.
Hmmm - OK, I'll dig a bit more... I guess I could also open a PR to revert back to before #23 if I don't find the answer soon...
Asked a question at https://github.com/vitejs/vite/discussions/12121
Fixes #26.