search

ome / ome-ngff-validator

Web page for validating OME-NGFF files
https://ome.github.io/ome-ngff-validator
BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Viewer logo fix2 #28

Closed will-moore closed 1 year ago

will-moore commented 1 year ago

Not seen an answer at https://github.com/vitejs/vite/discussions/12121 as to how to fix the original problem.

So this is an alternative approach... Since Vite build recognises imports to URLs if they are specified at the top, e.g. import copy_icon from "/copy_icon.png"; for the copy icon, and this is working when URLs to other icons fail (vite creates all the paths correctly in production deploy).

So this PR uses a URL generated in this way as a basis for URLs to other icons.

This also fixes the loading of OME/METADATA.xml which was broken in #23 E.g. test with https://deploy-preview-28--ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0048A/9846151.zarr/

netlify[bot] commented 1 year ago

Deploy Preview for ome-ngff-validator ready!

Name Link
Latest commit b3b6801387ed1c7bf3c87e25e9ff306467924aef
Latest deploy log https://app.netlify.com/sites/ome-ngff-validator/deploys/63f3926cda5f3c0008512649
Deploy Preview https://deploy-preview-28--ome-ngff-validator.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

will-moore commented 1 year ago

cc @joshmoore I'm hoping this one does the trick...

joshmoore commented 1 year ago

Hurrah!