search

ome / ome-ngff-validator

Web page for validating OME-NGFF files
https://ome.github.io/ome-ngff-validator
BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Swap chunkX and chunkY for cube lines #29

Closed will-moore closed 1 year ago

will-moore commented 1 year ago

Tiny bug fix...

The chunkX and chunkY lines drawn on the 3D cube are swapped, so that when chunks are rectangular (not square) then the chunks are "portrait" instead of "landscape" (and vice versa). E.g: https://ome.github.io/ome-ngff-validator/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0101A/13457537.zarr

Here, the chunk size is the same as the shape, so we shouldn't see any chunk-divider lines, but we do:

Screenshot 2023-05-18 at 21 57 18

This is fixed in this PR: https://deploy-preview-29--ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0101A/13457537.zarr

Screenshot 2023-05-22 at 14 34 25

netlify[bot] commented 1 year ago

Deploy Preview for ome-ngff-validator ready!

Name Link
Latest commit 3533421268f27fee5f2edb5f4379e2b4c6be0e39
Latest deploy log https://app.netlify.com/sites/ome-ngff-validator/deploys/646b6f59a167cb000712f2b5
Deploy Preview https://deploy-preview-29--ome-ngff-validator.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.