Closed will-moore closed 2 years ago
sbesson
commented
2 years ago Can't use the
````0.4``````schema to validate since it enforces``````"version": "0.4".
Also the 0.4 schema enforces keys like rowIndex and columnIndex that are not defined in earlier versions of the specification so even with a looser version definition this would not be an option.
Should we capture the backport the plate schemas to earlier versions as an issue on the ome/ngff repo?
joshmoore
commented
2 years ago Nice animation.
will-moore
commented
2 years ago I was hoping that https://github.com/ome/ngff/pull/127#issuecomment-1141379460 would fix v0.2 and v0.3 plate validation, but seems not to yet?
joshmoore
commented
2 years ago ome/ngff#127 should now be re-merged (sorry!) and the github pages should be re-deployed.
pwalczysko
commented
2 years ago Plate v0.3, concretely https://ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.3/idr0094A/7751.zarr is working fine now. Also tested couple of other plates from https://idr.github.io/ome-ngff-samples/, all were valid.
Which looks nice, but probably we should be thinking about having some portfolio of plates which are not valid ?
LGTM
joshmoore
commented
2 years ago some portfolio of plates which are not valid ?
This adds plate validation:
NB: UI is very basic just now - probably next job is to switch to some UI framework to make this easier. NB: This only works with a v0.4 plate since we don't have
plateandwellschemas available for0.1,0.2, 0.3. Can't use the0.4schema to validate since it enforces"version": "0.4"`.To test, deployed at: https://ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0072B/9512.zarr (v0.4) or e.g. https://ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.1/plates/5966.zarr (v0.1)