search

ome / ome-ngff-validator

Web page for validating OME-NGFF files
https://ome.github.io/ome-ngff-validator
BSD 2-Clause "Simplified" License
4 stars 3 forks source link

New svelte-based UI #5

Closed will-moore closed 2 years ago

will-moore commented 2 years ago

Using https://svelte.dev/ framework to build a nicer UI. Still using vite to build etc so that should still work the same 🤞

Deployed at e.g. https://ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.1/12689244.zarr

Screenshot 2022-06-21 at 09 24 20

will-moore commented 2 years ago

@joshmoore I wonder if you could set-up netlify for ome to build and deploy PR branches? I just tried it for my own repo, but it doesn't seem to build branches like this one (maybe because it's a PR to another repo).

will-moore commented 2 years ago

Thanks! I hope the background is not over-the-top (too playful)?

I've played with svelte on a side project https://idr-tables.netlify.app/ (https://github.com/will-moore/idr_tables) and it's really nice - it's one of the leading next-gen frameworks to follow React.

I need to play a bit more to fix the chunks on the 3D cubes and add "Tasks" and "Chunks" to the table to replicate:

Screenshot 2022-05-30 at 19 21 55

I think I understand what "Chunks" is: but what is "Tasks" and is it always chunks + 1?

That screenshot is from https://ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.1/9822152.zarr Ooops - I noticed 'Bytes' is not showing up there. Will check...

joshmoore commented 2 years ago

@joshmoore I wonder if you could set-up netlify for ome to build and deploy PR branches?

Done.

will-moore commented 2 years ago

Grrr - @joshmoore it looks like the deploy is failing because of some permissions. Can't access this PR/branch:

10:23:27 PM: git ref pull/5/head does not exist or you do not have permission
10:23:27 PM: Creating deploy upload records
10:23:27 PM: Failing build: Failed to prepare repo
10:23:27 PM: Failed during stage 'preparing repo': git ref pull/5/head does not exist

I wonder if there's some issue with me setting up netlify on the repo before transferring the repo to you. I could try and Delete my netlify deploy of this?

will-moore commented 2 years ago

OK, I'm done with adding stuff to this branch. Ready for review - re-deployed as above.

will-moore commented 2 years ago

Updated screenshot in description to show current state

joshmoore commented 2 years ago

Thanks for all the changes, @will-moore. The latest netlify build looks good, but we should try to get those building on the PRs themselves.