ome / ome-ngff-validator

Web page for validating OME-NGFF files
https://ome.github.io/ome-ngff-validator
BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Handle no ?source=... show message #8

Closed will-moore closed 2 years ago

will-moore commented 2 years ago

This fixes the blank page at https://ome.github.io/ome-ngff-validator/ (no source) and shows a helpful message and example link:

Screenshot 2022-06-22 at 00 28 53
netlify[bot] commented 2 years ago

Deploy Preview for ome-ngff-validator ready!

Name Link
Latest commit 768caf819a89536f2151dd4f7ffacdc67e2086b0
Latest deploy log https://app.netlify.com/sites/ome-ngff-validator/deploys/62b30e0e6e49e707c1b18cc4
Deploy Preview https://deploy-preview-8--ome-ngff-validator.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

will-moore commented 2 years ago

The deploy is green, but the link https://deploy-preview-8--ome-ngff-validator.netlify.app/ is 404 (with a link to trouble-shooting, which talks about missing index.html). But the logs at https://app.netlify.com/sites/ome-ngff-validator/deploys/62b2544dd0c63c0008abc6cd look good:

12:29:39 AM: dist/index.html                  5.18 KiB
12:29:39 AM: dist/assets/index.3acb94f6.css   5.83 KiB / gzip: 1.56 KiB
12:29:39 AM: dist/assets/index.3665eeca.js    160.64 KiB / gzip: 50.94 KiB`
joshmoore commented 2 years ago

Were there any particular configurations you set for the netlify deploy, @will-moore ?

will-moore commented 2 years ago

The only thing I remember doing was choosing the deploy URL (site name). I wonder if this is something that got broken in #7 (although I can't see why it would, but I could push a temp revert of that here and see if it helps...)

will-moore commented 2 years ago

Hmm - that didn't work... Removed temp commit.

Reading.. https://answers.netlify.com/t/support-guide-i-ve-deployed-my-site-but-i-still-see-page-not-found/125

Do you see the download button it mentions on any of the deploy log pages? e.g. https://app.netlify.com/sites/ome-ngff-validator/deploys/62b2e01d53b49800086d7a72 ?

I don't, but is that because I'm not logged-in as ome or because it isn't there? There seem to be a lot of related posts on the forums: I haven't seen anything that helps yet, but the netlify support seems good so we could try asking...

will-moore commented 2 years ago

That last commit was based on https://answers.netlify.com/t/site-cannot-be-accessed-broken-link-or-url-that-doesnt-exist/3729/27 but didn't fix it.

joshmoore commented 2 years ago

Do you see the download button it mentions on any of the deploy log pages?

No, no download button.

Edit: oops I missed the small down arrow.

joshmoore commented 2 years ago

The build is back! :tada:

will-moore commented 2 years ago

@joshmoore I'm not sure what went wrong with the latest gh-pages build after this PR was merged (https://github.com/ome/ome-ngff-validator/actions/runs/2542337160), but it failed so that this PR isn't deployed at https://ome.github.io/ome-ngff-validator/

joshmoore commented 2 years ago

A re-run fixed it: https://github.com/ome/ome-ngff-validator/actions/runs/2542337160