Open DimitriPapadopoulos opened 1 year ago
And here, the type hint for well
is str
. Why use str(well)
? Defensive programming?
Isn't parent_dir
a str
? It could be perhaps None
(if input_path
is empty or doesn't contain a slash) , but do you really want to use "None"
in that corner case?
https://github.com/ome/ome-zarr-py/blob/6a1de2a0924e821fecec7ac3ba8790c0a3ae234f/ome_zarr/utils.py#L58-L59
In the following code, the type hint for
version
isstr
. Yet, the code has been modified to handle floats too (#189).Should the type hint be changed from
str
tostr | float
?https://github.com/ome/ome-zarr-py/blob/6a1de2a0924e821fecec7ac3ba8790c0a3ae234f/ome_zarr/format.py#L12-L16