ome / ome-zarr-py

Implementation of next-generation file format (NGFF) specifications for storing bioimaging data in the cloud.
https://pypi.org/project/ome-zarr
Other
156 stars 54 forks source link

Pin numpy<2 in setup.py #385

Closed will-moore closed 5 months ago

will-moore commented 5 months ago

numpy 2.0.0 has been released with breaking changes. Avoid installing till this can be reviewed etc. Same as https://github.com/ome/omero-py/pull/414

cc @sbesson

will-moore commented 5 months ago

Tests failing with Error: Codecov token not found. Please provide Codecov token with -t flag. Reading https://github.com/marketplace/actions/codecov doesn't indicate anything obvious has changed.

What I see at https://github.com/ome/ome-zarr-py/settings doesn't look like https://docs.codecov.com/docs/adding-the-codecov-token - I don't see any tokens etc.

joshmoore commented 5 months ago

I do see the token, but the environment variable wasn't set. I've pushed a commit that matches what I did in https://github.com/zarr-developers/zarr-python/pull/1647. Waiting to see if it goes green now.

joshmoore commented 5 months ago

Somehow codecov is only not finding the token on 3.12 (😕) I'm going to merge as is since this is clearly passing most workflows and we may have to come back to it soon.