search

ome / ome_zarr_test_suite

Test suite of reader and writer implementations
4 stars 6 forks source link

Test vizarr #1

Open will-moore opened 3 years ago

will-moore commented 3 years ago

@joshmoore I assume we could test vizarr using a Docker container specified in this repo instead of in the vizarr repo, in order not to pollute that repo with OME's code?

joshmoore commented 3 years ago

Exactly. If there's a Dockerfile somewhere that does what you want, then you can follow https://github.com/ome/ome_zarr_test_suite/blob/main/scripts/omero_ms_zarr_fake . Otherwise, create a subdirectory there that contains a Dockerfile and we'll go from there. :+1:

will-moore commented 3 years ago

I was thinking of:

1) Using Docker with http-server to serve the test data (with cors).

2) Then checkout and build a particular branch of vizarr, or possibly use the PR builds e.g. PR 85 deploy-preview-85 to consume and display the data.

3) Finally, use pageres-cli to grab a browser screenshot of the app. Either this could be compared with a known valid screenshot, or some other simpler validation that at least the image is displayed.

I managed 1) OK, but failed with 3) - getting errors with puppeteer which referred me to https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md#running-puppeteer-in-docker but I didn't manage to get any of the solutions there working

joshmoore commented 3 years ago

Don't know if it will be of any use but seealso: https://github.com/zarr-developers/zarr_implementations/pull/21