search

ome / ome_zarr_test_suite

Test suite of reader and writer implementations
4 stars 6 forks source link

Version 0.3 sample #11

Closed will-moore closed 3 years ago

will-moore commented 3 years ago

Added a sample v0.3 file, generated by copying the v0.2 file and making some changes since bioformats2raw doesn't generate v0.3 data yet. Can be updated when it does.

Also added info to README and added to the checksum test check. Do we want to check different values based on version number here?

The v0.3 data passes all the existing tests (info, download and "checksum") since they don't assume data is 5D. Also, the v0.3 data passes even without the axes metadata required by the spec. I guess this is OK since the job of ome-zarr-py is not to validate, but do we want to add this somewhere (either in ome-zarr-py or in this test repo)?

joshmoore commented 3 years ago

I guess this is OK since the job of ome-zarr-py is not to validate, but do we want to add this somewhere (either in ome-zarr-py or in this test repo)?

Rather than add logic to this repo, I would error on the side of an ome_zarr validate method (if not just a part of info)