search

ome / omero-blitz

Gradle project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
0 stars 15 forks source link

Missing requirements from the build instructions #123

Open aherbert opened 2 years ago

aherbert commented 2 years ago

My aim is to rebuild omero-blitz-5.5.8.jar with more connection logging.

The build instructions only require a JDK > 1.8. However they should be updated to also require:

Building using the latest gradle versions (v7.4 and v6.9.2) have an error with this line tasks."generateObjectFactoryRegistrar...

In my git clone:

> git checkout v5.5.8
> export ICE_HOME=/opt/ice-3.6.5
> gradle -version

------------------------------------------------------------
Gradle 7.4
------------------------------------------------------------

Build time:   2022-02-08 09:58:38 UTC
Revision:     f0d9291c04b90b59445041eaa75b2ee744162586

Kotlin:       1.5.31
Groovy:       3.0.9
Ant:          Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM:          1.8.0_311 (Oracle Corporation 25.311-b11)
OS:           Linux 4.15.0-167-generic amd64

> gradle build
FAILURE: Build failed with an exception.

* Where:
Build file '/home/ah403/git/omero-blitz/build.gradle' line: 177

* What went wrong:
A problem occurred evaluating root project 'omero-blitz'.
> Could not create task ':generateObjectFactoryRegistrarPsql'.
   > Could not create task of type 'FileGeneratorTask'.
      > Please use the ObjectFactory.mapProperty() method to create a property of type Map<K, V>.
jburel commented 2 years ago

Thanks @aherbert for the issue. This is an oversight from our part since we have slice2java in the gihub action to test the build see https://github.com/ome/omero-blitz/blob/master/.github/workflows/gradle.yml. We will update the doc accordingly

We are aware that the build (problem not in omero-blitz but in the upstream repo) does not work with Gradle 7, we need to review all the repositories using Gradle and fix the issue

aherbert commented 2 years ago

Thanks for the info.

I managed to get it to build and adding the logging. My connection issue is an Ice.ConnectTimeoutException as the server apparently never responds to the connection request. However this is a new server setup with access guarded by a VPN. Currently we cannot get it to work and it may be that the connection request never reaches the server, or the server response is not passed back.

So there are no bugs in omero-blitz, just problems with our over zealous network security.