search

ome / omero-blitz

Gradle project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
0 stars 15 forks source link

Fix conversion NPE for PIXELS and REFERENCEFRAME #126

Closed chris-allan closed 2 years ago

chris-allan commented 2 years ago

This PR follows on from #76 based on the investigation from glencoesoftware/omero-ms-image-region#99 ensuring that conversions from PIXELS or REFERENCEFRAME throw the correct exceptions just like conversions to those units. Since these two units are the only examples across the seven (ElectricalPotential, Frequency, Length, Power, Pressure, Temperature, Time) originally modified I made the decision just to set up empty conversion maps rather than modify all the implementations.

The unit tests for the unit infrastructure have also been reactivated as part of this PR.

@dominikl, @jburel: You will definitely want to make sure this does not break things vs. what the Java gateway is doing.

jburel commented 2 years ago

Looking at the gateway classes, PIXELS and REFERENCEFRAME are used in the Pojos when value is null. I have not seen any error reported when consuming the Pojos in insight for example @dominikl have you?

dominikl commented 2 years ago

Me neither, I think it's fine 👍

jburel commented 2 years ago

Merging, before doing another release following the release of BF 6.9.1