add DEBUG logging for successful repository file deletions

ome / omero-blitz

Gradle project containing Ice remoting code for OMERO

https://www.openmicroscopy.org/omero

GNU General Public License v2.0

0 stars 15 forks source link

add DEBUG logging for successful repository file deletions #19

Closed mtbc closed 5 years ago

mtbc commented 5 years ago

Most server file deletions are logged at debug level but this appears to be an exception. To test, try deleting some images after first including in etc/logback.xml,

<logger name="ome.services.blitz.repo.AbstractRepositoryI" level="DEBUG"/>

dominikl commented 5 years ago

Looks alright, but no idea how to test / create a build with this PR.

mtbc commented 5 years ago

Maybe if I open a PR with that logging config change then it might be possible to use west to test depending on @joshmoore's work.

joshmoore commented 5 years ago

no idea how to test / create a build with this PR.

In this case of this PR, it's actually fairly straight-forward to do it yourself:

omero-blitz: check out this repository and build (gradle publishToMavenLocal)
openmicroscopy: set versions.omero-blitz to 5.5.0-SNAPSHOT to match the jar you just built
openmicroscopy: build as usual (./build.py)

dominikl commented 5 years ago

Works, good to merge 👍

2019-03-07 13:26:24,628 DEBUG [      o.s.blitz.repo.AbstractRepositoryI] (1-thread-2) DELETED: CheckedPath(root_0/2019-03/07/11-18-01.956/ACA1-1000_AF594_03_R3D.ome.tiff)
2019-03-07 13:26:24,628 DEBUG [      o.s.blitz.repo.AbstractRepositoryI] (1-thread-2) DELETED: CheckedPath(root_0/2019-03/07/11-18-01.956.log)