search

ome / omero-blitz

Gradle project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
0 stars 15 forks source link

Do real file deletions in same order as deletion processing. #43

Closed mtbc closed 5 years ago

mtbc commented 5 years ago

https://github.com/openmicroscopy/openmicroscopy/pull/3751 and https://github.com/ome/omero-server/pull/14 carefully order file deletions. The need for that latest PR was detected by the _fs_dir_delete database trigger however the need for this PR is probably being concealed by [trello] repo file deletion fails silently. This PR aims to ensure that the deletions from the underlying filesystem occur in the same order as from the database. This may become more of an issue when data deletion more commonly includes directories due to https://github.com/openmicroscopy/management_tools/pull/921 and its like which the extra-keen may wish to use for thorough testing.

To test, try deleting complex data like SPW and watch for regressions in what is deleted from the binary repository. In normal OMERO usage thumbnails, image files, etc. should be deleted exactly as before.

rgozim commented 5 years ago

Code wise, everything looks okay. Is there a pre-built omero server somewhere that I can download to test this, or should I build everything locally?

mtbc commented 5 years ago

https://web-proxy.openmicroscopy.org/west-ci/job/OMERO-build/lastSuccessfulBuild/artifact/src/target/

mtbc commented 5 years ago

(though at some point merge-ci might appear!)

mtbc commented 5 years ago

So maybe now https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-build/lastSuccessfulBuild/artifact/src/target/!

jburel commented 5 years ago

Files were deleted from binary repo. I will do further testing again today

jburel commented 5 years ago

Imported some Cellworx plates The files are correctly deleted, the log file associated to the directory containing the data e.g. 09-59-43.839.log is also removed. Currently this leaves an empty directory e.g. 09-59-43.839. From discussion with @mtbc, this is currently expected

joshmoore commented 5 years ago

Assuming the above means, "good to merge" and merging. If a correction is needed, we can get a follow-up in for 5.5.0.