Zarr export tests - Githubissues

will-moore commented 2 years ago

Starting to add tests for omero-cli-zarr. cc @sbesson

sbesson commented 2 years ago

Fails with

+ python setup.py test -t test -i /opt/omero/server/OMERO.server/etc/ice.config -vs
/opt/omero/server/venv3/lib64/python3.6/site-packages/setuptools/installer.py:30: SetuptoolsDeprecationWarning: setuptools.installer is deprecated. Requirements should be satisfied by a PEP 517 installer.
  SetuptoolsDeprecationWarning,
/omero-cli-zarr/.eggs/setuptools_scm-6.4.2-py3.6.egg/setuptools_scm/git.py:105: UserWarning: "/omero-cli-zarr" is shallow and may cause errors
  warnings.warn(f'"{wd.path}" is shallow and may cause errors')
Traceback (most recent call last):
  File "setup.py", line 43, in <module>
    use_scm_version={"write_to": "src/omero_zarr/_version.py"},
  File "/opt/omero/server/venv3/lib64/python3.6/site-packages/setuptools/__init__.py", line 153, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib64/python3.6/distutils/core.py", line 108, in setup
    _setup_distribution = dist = klass(attrs)
  File "/opt/omero/server/venv3/lib64/python3.6/site-packages/setuptools/dist.py", line 463, in __init__
    for k, v in attrs.items()
  File "/usr/lib64/python3.6/distutils/dist.py", line 281, in __init__
    self.finalize_options()
  File "/opt/omero/server/venv3/lib64/python3.6/site-packages/setuptools/dist.py", line 837, in finalize_options
    ep(self)
  File "/opt/omero/server/venv3/lib64/python3.6/site-packages/setuptools/dist.py", line 858, in _finalize_setup_keywords
    ep.load()(self, ep.name, value)
  File "/omero-cli-zarr/.eggs/setuptools_scm-6.4.2-py3.6.egg/setuptools_scm/integration.py", line 75, in version_keyword
    _assign_version(dist, config)
  File "/omero-cli-zarr/.eggs/setuptools_scm-6.4.2-py3.6.egg/setuptools_scm/integration.py", line 48, in _assign_version
    maybe_version = _get_version(config)
  File "/omero-cli-zarr/.eggs/setuptools_scm-6.4.2-py3.6.egg/setuptools_scm/__init__.py", line 164, in _get_version
    template=config.write_to_template,
  File "/omero-cli-zarr/.eggs/setuptools_scm-6.4.2-py3.6.egg/setuptools_scm/__init__.py", line 75, in dump_version
    with open(target, "w") as fp:
PermissionError: [Errno 13] Permission denied: 'src/omero_zarr/_version.py'

Possibly something that https://github.com/ome/omero-test-infra/issues/60 could solve by invoking pytest directly?

will-moore commented 2 years ago

The workings of omero-test-infra are a bit confusing so I don't know the answer to that. Why are no other repos affected by this issue?

sbesson commented 2 years ago

Pretty certain this is the result of this being one of the few OMERO plugins to use setuptools_scm (which internally writes the version) - see https://github.com/search?q=org%3Aome+setuptools_scm&type=code.

I think the current logic is that the installation command is executed as root in but the test command is executed as the local user. I cannot comment on the impact of modifying this assumption.

snoopycrimecop commented 9 months ago

Conflicting PR. Removed from build OMERO-plugins-push#343. See the console output for more details. Possible conflicts:

Upstream changes
- src/omero_zarr/raw_pixels.py

--conflicts