search

ome / omero-cli-zarr

https://pypi.org/project/omero-cli-zarr/
GNU General Public License v2.0
15 stars 10 forks source link

Use correct dimension_separator when downsampling #144

Closed will-moore closed 1 year ago

will-moore commented 1 year ago

I noticed that a bug introduced in https://github.com/ome/omero-cli-zarr/pull/134 When creating pyramids with downsample_pyramid_on_disk() the da.to_zarr() doesn't respect dimension separator.

For example of data exported with this issue: see https://ome.github.io/ome-ngff-validator/?source=https://uk1s3.embassy.ebi.ac.uk/idr0036/zarr/4403.zarr/A/1/0/

Fix is similar to https://github.com/ome/ome-zarr-py/pull/243

To test:

$ omero zarr export Image:123

check that array at 123.zarr/1/ has dimension separator /

will-moore commented 1 year ago

Fix released in omero-cli-zarr 0.5.3

dominikl commented 1 year ago

👍 Shall I export idr0036 with this fix again?