search

ome / omero-cli-zarr

https://pypi.org/project/omero-cli-zarr/
GNU General Public License v2.0
15 stars 10 forks source link

scm version fix #159

Closed will-moore closed 7 months ago

will-moore commented 7 months ago

Use version_file instead of write_to for scm_version

As a breaking change in https://github.com/pypa/setuptools_scm/blob/main/CHANGELOG.md#v800 is "introduce version_file as replacement for write_to".

This PR makes the corresponding change.

joshmoore commented 7 months ago

Re-opening to trigger the job since this looks very much unrelated:

    fatal: unable to access 'https://github.com/ome/omero-cli-zarr/': The requested URL returned error: 500
will-moore commented 7 months ago

In testing locally, with pip install . from source, the initial change above didn't help (after deleting the .eggs/ dir etc). The simplest fix that did work for me so far was to pin setuptools_scm:

setup_requires=["setuptools_scm==7.1.0"],
will-moore commented 7 months ago

With that 2nd commit, things are working as before for me locally. I can pip install -e . and everything works.

In the short term, if others are happy, I'd like to simply get that fix in and release, possibly including https://github.com/ome/omero-cli-zarr/pull/147 (although that could also come in a follow-up release).

snoopycrimecop commented 7 months ago

Conflicting PR. Removed from build OMERO-plugins-push#366. See the console output for more details. Possible conflicts:

--conflicts

snoopycrimecop commented 7 months ago

Conflicting PR. Removed from build OMERO-plugins-push#367. See the console output for more details. Possible conflicts:

--conflicts Conflict resolved in build OMERO-plugins-push#368. See the console output for more details.

will-moore commented 7 months ago

@joshmoore I think this is now conflicting with your versionneer PR #156. Could you maybe close that for now and see if we can get this fix in? Thanks

joshmoore commented 7 months ago

:+1: Done.

will-moore commented 7 months ago

@joshmoore @jburel Any objections to getting this merged and released (would be good to get a release that isn't broken)?