Closed sbesson closed 3 years ago
Looks good for me, could install and use the plugin from this PR without any additional libraries installed previously 👍
Unless there is a strong objection, once this is reviewed and accepted, I'd like to use this occasion to release ome-zarr-py
AND omero-cli-zarr
as 0.1.0
.
This dependency removal is a classical example where, from a consumer perspective, changes like https://github.com/ome/ome-zarr-py/pull/89 should be communicated via a 0.x.0
version increment. Consumers can then review the implications in terms of breaking behavior and the impact on their code. /cc @constantinpape
0.1.0
works for me.
Sounds good!
Thanks. Just waiting for the review of @will-moore and I will action the release
Looks good, thanks! Tested locally on landscape image and all resolutions are also landscape. Good to merge.
Previously, the CLI plugin relied on the
opencv
dependency transitively throughome-zarr-py
. However, this dependency has been dropped as part of the 0.3 specification support in https://github.com/ome/ome-zarr-py/pull/89. With the release ofome-zarr-py==0.0.24
, @dominikl has established the standard installation ofomero-cli-zarr
is currently broken (without a manual installation of the dependency):This PR proposes to fix this installation issue and align the downsampling implementation to use the same library as
ome-zarr-py
.A follow-up refactoring would probably be to delegate the downsampling logic to a relevant
ome-zarr-py
API. @will-moore