search

ome / omero-downloader

An OMERO client for downloading data in bulk from the server.
https://www.openmicroscopy.org/omero/apps/
GNU General Public License v2.0
4 stars 5 forks source link

Upgrade 5.5 #22

Closed jburel closed 5 years ago

jburel commented 5 years ago
mtbc commented 5 years ago

Good idea! Though now when I build I get new messages,

[WARNING] The POM for org.jboss:jbossorg-jdocbook-style:jdocbook-style:1.1.0 is missing, no dependency information available
[WARNING] The POM for org.jboss:jbossorg-docbook-xslt:jar:1.1.0 is missing, no dependency information available
[WARNING] The POM for org.jboss:jbossorg-fonts:jdocbook-style:1.0.0 is missing, no dependency information available
[WARNING] The POM for org.jboss.jdocbook:jdocbook-core:jar:1.0.4 is missing, no dependency information available
[WARNING] The POM for net.sf.docbook:docbook:jar:1.74.0 is missing, no dependency information available

I wonder why they've started appearing with this change.

jburel commented 5 years ago

This is similar to the javadoc error in omero-gateway-java The dependencies are excluded in omero-gateway-java leading to the warnings

joshmoore commented 5 years ago

Looks like these versions are not on maven central: https://search.maven.org/search?q=g:net.sf.docbook%20AND%20a:docbook&core=gav so I'd think we either need to exclude more so we don't attempt to add them or their repositories might need to be added even if we're not going to use them (https://stackoverflow.com/questions/45730541/the-pom-for-is-missing-no-dependency-information-available-even-though-it?rq=1)

mtbc commented 5 years ago

exclude more so we don't attempt to add them

Maybe the dependency tree will reveal which to try.

mtbc commented 5 years ago

I'm having trouble figuring out what it is that's making it look for docbook.

mtbc commented 5 years ago

Let's go ahead and get this in. It works and we can figure out the dependency stuff later. https://github.com/ome/omero-downloader/pull/22#issuecomment-502570748 suggests a to-do for the Java Gateway?

pwalczysko commented 5 years ago

Tested today after building the master branch from here on Mac.

I think this is ready to release cc @mtbc @jburel @joshmoore @sbesson

sbesson commented 5 years ago

Is this effectively0.2.0 as this will break compatibility with OMERO 5.4 instances?

mtbc commented 5 years ago

No idea. :smiley: Happy to go with any strong feelings anybody has on this so ... probably?