5 6 1 (second attempt) - Githubissues

ome / omero-dropbox

OMERO.dropbox server for watching directories

https://www.openmicroscopy.org/omero

GNU General Public License v2.0

1 stars 6 forks source link

5 6 1 (second attempt) #13

Closed joshmoore closed 4 years ago

joshmoore commented 4 years ago

Runs after the first failed to register since an exception had been thrown. This corrects the problem (path(bytes_name) throws) but does not deal with the deeper issue that the service should be more fault tolerant. Fixes include:

NativeKeyDict which maps stores all elements under str keys (even if bytes)
Log all messages via format % (values) rather than log(fmt, *values)

close #12

mtbc commented 4 years ago

I think it's worth making a release as you've observed that the fix works.

joshmoore commented 4 years ago

Also thanks for the quick overview (external comment). Moving forward and a 5.6.2 is always the next option. Can deal with the failing travis status with the next PR.